Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 466038: Remove bzip2 decoding support completely. (Closed)

Created:
11 years ago by Lei Zhang
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove bzip2 decoding support completely. BUG=14801, 26577 TEST=see bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34047

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -680 lines) Patch
M net/base/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D net/base/bzip2_filter.h View 1 chunk +0 lines, -88 lines 0 comments Download
D net/base/bzip2_filter.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D net/base/bzip2_filter_unittest.cc View 1 chunk +0 lines, -406 lines 0 comments Download
M net/base/filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/filter.cc View 1 4 chunks +0 lines, -15 lines 0 comments Download
M net/base/filter_unittest.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M net/net.gyp View 4 chunks +0 lines, -6 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
Another case of compressed tarball being decompressed by the network stack.
11 years ago (2009-12-04 21:30:12 UTC) #1
jar (doing other things)
I'm pretty sure we disabled bzip encoding, because it was inducing incompatibilities with poor proxies ...
11 years ago (2009-12-04 22:37:21 UTC) #2
Lei Zhang
On 2009/12/04 22:37:21, jar wrote: > I'm pretty sure we disabled bzip encoding, because it ...
11 years ago (2009-12-05 00:32:00 UTC) #3
jar (doing other things)
Here is the committed CL that disabled advertisement of support for bzip: http://codereview.chromium.org/147058 <http://codereview.chromium.org/147058>As a ...
11 years ago (2009-12-05 06:13:50 UTC) #4
Lei Zhang
On 2009/12/05 06:13:50, jar wrote: > Here is the committed CL that disabled advertisement of ...
11 years ago (2009-12-07 21:09:21 UTC) #5
jar (doing other things)
+1 to remove bzip entirely. All it would take at this point is to remove ...
11 years ago (2009-12-07 21:41:57 UTC) #6
Lei Zhang
On 2009/12/07 21:41:57, jar wrote: > +1 to remove bzip entirely. Ok, I think I ...
11 years ago (2009-12-07 22:53:12 UTC) #7
jar (doing other things)
11 years ago (2009-12-07 23:21:04 UTC) #8
LGTM

Thanks!

Powered by Google App Engine
This is Rietveld 408576698