Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 147058: Start to disable bzip2 support. First step: Stop advertising support.... (Closed)

Created:
11 years, 6 months ago by jar (doing other things)
Modified:
9 years, 7 months ago
Reviewers:
huanr
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

Start to disable bzip2 support. First step: Stop advertising support. Although it would be nice to just yank it all, it is good to do so slowly so that any cached data that might required bzip2 decoding will still decode and render. Maybe I'm being paranoid... but this seems like a nice first small step. I also disabled the tests that depend on this modified code, and linted the unittest file a bit. BUG=14801 TEST= Be sure you can still view http://ukcp09.defra.gov.uk/content/view/16/6/index.html which is (currently) bzip encoded. r=hunar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19173

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M net/url_request/url_request_http_job.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 3 4 5 6 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jar (doing other things)
11 years, 6 months ago (2009-06-24 17:35:00 UTC) #1
jar (doing other things)
11 years, 6 months ago (2009-06-24 20:34:08 UTC) #2
huanr
11 years, 6 months ago (2009-06-24 20:37:51 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698