Added CommandBufferClient, CommandBufferStub and some IPC messages....

Added CommandBufferProxy, CommandBufferStub. Replaced NPAPI with IPC for synchronous messages. WebPluginDelegateImpl can instantiate a command buffer. Removed remaining dependencies on NPAPI.
TEST=none
BUG=none

[apatrick_chromium, 2009-12-09 21:42:12]

Check the dependencies on gfx::PluginWindowHandle. I'm not sure where the app
project belongs in the project hierarchy.

[jam, 2009-12-10 00:09:55]

http://codereview.chromium.org/465040/diff/9001/10008
File chrome/common/command_buffer_messages_internal.h (right):

http://codereview.chromium.org/465040/diff/9001/10008#newcode9
chrome/common/command_buffer_messages_internal.h:9: 
nit: extra line

http://codereview.chromium.org/465040/diff/9001/10009
File chrome/plugin/command_buffer_stub.cc (right):

http://codereview.chromium.org/465040/diff/9001/10009#newcode1
chrome/plugin/command_buffer_stub.cc:1: // Copyright (c) 2006-2008 The Chromium
Authors. All rights reserved.
nit: date

http://codereview.chromium.org/465040/diff/9001/10009#newcode11
chrome/plugin/command_buffer_stub.cc:11: using base::SharedMemory;
you always refer to this with base:: anyways, so can you just remove this line?

http://codereview.chromium.org/465040/diff/9001/10009#newcode28
chrome/plugin/command_buffer_stub.cc:28: // TODO(apatrick): Figure out when this
happens and what to do about it.
this occurs when the channel to the renderer is stopped, i.e. because the
renderer crashed or it removed all the plugin instances and hence destroyed the
channel.

http://codereview.chromium.org/465040/diff/9001/10009#newcode45
chrome/plugin/command_buffer_stub.cc:45: // Early out if already initialized.
why would this function get called twice?  if you control the caller, better to
just add a dcheck/check and not add code that's not necessary

http://codereview.chromium.org/465040/diff/9001/10010
File chrome/plugin/command_buffer_stub.h (right):

http://codereview.chromium.org/465040/diff/9001/10010#newcode1
chrome/plugin/command_buffer_stub.h:1: // Copyright (c) 2006-2008 The Chromium
Authors. All rights reserved.
nit: 2009

http://codereview.chromium.org/465040/diff/9001/10010#newcode18
chrome/plugin/command_buffer_stub.h:18: namespace command_buffer {
why do we need a namespace for code in chrome\plugin or chrome\renderer?  I ask
because command_buffer::CommandBufferStub seems a little redundant.

http://codereview.chromium.org/465040/diff/9001/10010#newcode36
chrome/plugin/command_buffer_stub.h:36: int route_id() const {
nit: we usually put small getters like this on one line

http://codereview.chromium.org/465040/diff/9001/10010#newcode54
chrome/plugin/command_buffer_stub.h:54: PluginChannel* channel_;
why not scoped_refptr<PluginChannel>?

http://codereview.chromium.org/465040/diff/9001/10023
File chrome/plugin/webplugin_delegate_stub.cc (right):

http://codereview.chromium.org/465040/diff/9001/10023#newcode363
chrome/plugin/webplugin_delegate_stub.cc:363: *route_id = 0;
nit: this line seems unnecessary, since if ENABLE_PEPPER isn't defined, the
message won't be sent.

http://codereview.chromium.org/465040/diff/9001/10012
File chrome/renderer/command_buffer_proxy.cc (right):

http://codereview.chromium.org/465040/diff/9001/10012#newcode40
chrome/renderer/command_buffer_proxy.cc:40: // is responsible for duplicating
the handle. This might not be true for
nit "the is"

http://codereview.chromium.org/465040/diff/9001/10011
File chrome/renderer/command_buffer_proxy.h (right):

http://codereview.chromium.org/465040/diff/9001/10011#newcode64
chrome/renderer/command_buffer_proxy.h:64: PluginChannelHost* channel_;
nit: scoped_refptr

http://codereview.chromium.org/465040/diff/9001/10001
File gpu/command_buffer/service/command_buffer_service.h (right):

http://codereview.chromium.org/465040/diff/9001/10001#newcode21
gpu/command_buffer/service/command_buffer_service.h:21: class
CommandBufferService : public CommandBuffer {
nit: command_buffer::CommandBufferService seems redundant

http://codereview.chromium.org/465040/diff/9001/10002
File gpu/gpu.gyp (left):

http://codereview.chromium.org/465040/diff/9001/10002#oldcode309
gpu/gpu.gyp:309: 'np_utils/webkit_browser.h',
some of these files are still in the tree.  are they currently or planned to be
used?  if not, why not delete them and bring them out of the svn history if we
find out otherwise?

http://codereview.chromium.org/465040/diff/9001/10004
File gpu/gpu_plugin/gpu_plugin_object.h (left):

http://codereview.chromium.org/465040/diff/9001/10004#oldcode1
gpu/gpu_plugin/gpu_plugin_object.h:1: // Copyright (c) 2006-2008 The Chromium
Authors. All rights reserved.
rietveld is showing this file and the corresponding cc file as "M" instead of
"D", is it messing up and the file is really deleted in your checkout?

[jam, 2009-12-10 00:11:22]

http://codereview.chromium.org/465040/diff/9001/10007
File chrome/common/command_buffer_messages.h (right):

http://codereview.chromium.org/465040/diff/9001/10007#newcode8
chrome/common/command_buffer_messages.h:8: #define MESSAGES_INTERNAL_FILE
"chrome/common/command_buffer_messages_internal.h"  // NOLINT
nit: please no NOLINT

[greggman, 2009-12-10 01:05:49]

LGTM

http://codereview.chromium.org/465040/diff/9001/10010
File chrome/plugin/command_buffer_stub.h (right):

http://codereview.chromium.org/465040/diff/9001/10010#newcode36
chrome/plugin/command_buffer_stub.h:36: int route_id() const {
On 2009/12/10 00:09:55, John Abd-El-Malek wrote:
> nit: we usually put small getters like this on one line

Please do not put this on one line. It makes it impossible to debug because
putting a breakpoint on the getter will not have a valid "this" pointer until it
debugger reaches line 37

[jam, 2009-12-10 20:30:55]

http://codereview.chromium.org/465040/diff/9001/10010
File chrome/plugin/command_buffer_stub.h (right):

http://codereview.chromium.org/465040/diff/9001/10010#newcode36
chrome/plugin/command_buffer_stub.h:36: int route_id() const {
On 2009/12/10 01:05:49, greggman wrote:
> On 2009/12/10 00:09:55, John Abd-El-Malek wrote:
> > nit: we usually put small getters like this on one line
> 
> Please do not put this on one line. It makes it impossible to debug because
> putting a breakpoint on the getter will not have a valid "this" pointer until
it
> debugger reaches line 37

this is used all over the chrome code though, and we haven't had much problems
with it.  if someone really wants to add a breakpoint on that line, they could
always modify the line.  it does make a small difference whether a getter is 3
lines or 1.  especially if it's 3, then you'll probably want another empty line
afterwards...  note that an example of this is given twice in the google C++
style guide.

[apatrick, 2009-12-10 22:03:02]

I'm running the win trybot again. I think I just issued the job at a bad time.
Can you check the DEPS changes. I'm not sure if the dependencies on app are
legit.

http://codereview.chromium.org/465040/diff/9001/10007
File chrome/common/command_buffer_messages.h (right):

http://codereview.chromium.org/465040/diff/9001/10007#newcode8
chrome/common/command_buffer_messages.h:8: #define MESSAGES_INTERNAL_FILE
"chrome/common/command_buffer_messages_internal.h"  // NOLINT
On 2009/12/10 00:11:22, John Abd-El-Malek wrote:
> nit: please no NOLINT

Done.

http://codereview.chromium.org/465040/diff/9001/10008
File chrome/common/command_buffer_messages_internal.h (right):

http://codereview.chromium.org/465040/diff/9001/10008#newcode9
chrome/common/command_buffer_messages_internal.h:9: 
On 2009/12/10 00:09:55, John Abd-El-Malek wrote:
> nit: extra line

Done.

http://codereview.chromium.org/465040/diff/9001/10009
File chrome/plugin/command_buffer_stub.cc (right):

http://codereview.chromium.org/465040/diff/9001/10009#newcode1
chrome/plugin/command_buffer_stub.cc:1: // Copyright (c) 2006-2008 The Chromium
Authors. All rights reserved.
On 2009/12/10 00:09:55, John Abd-El-Malek wrote:
> nit: date

Done.

http://codereview.chromium.org/465040/diff/9001/10009#newcode11
chrome/plugin/command_buffer_stub.cc:11: using base::SharedMemory;
On 2009/12/10 00:09:55, John Abd-El-Malek wrote:
> you always refer to this with base:: anyways, so can you just remove this
line?

Done.

http://codereview.chromium.org/465040/diff/9001/10009#newcode45
chrome/plugin/command_buffer_stub.cc:45: // Early out if already initialized.
On 2009/12/10 00:09:55, John Abd-El-Malek wrote:
> why would this function get called twice?  if you control the caller, better
to
> just add a dcheck/check and not add code that's not necessary

Done.

http://codereview.chromium.org/465040/diff/9001/10010
File chrome/plugin/command_buffer_stub.h (right):

http://codereview.chromium.org/465040/diff/9001/10010#newcode1
chrome/plugin/command_buffer_stub.h:1: // Copyright (c) 2006-2008 The Chromium
Authors. All rights reserved.
On 2009/12/10 00:09:55, John Abd-El-Malek wrote:
> nit: 2009

Done.

http://codereview.chromium.org/465040/diff/9001/10010#newcode18
chrome/plugin/command_buffer_stub.h:18: namespace command_buffer {
On 2009/12/10 00:09:55, John Abd-El-Malek wrote:
> why do we need a namespace for code in chrome\plugin or chrome\renderer?  I
ask
> because command_buffer::CommandBufferStub seems a little redundant.

Done.

http://codereview.chromium.org/465040/diff/9001/10010#newcode36
chrome/plugin/command_buffer_stub.h:36: int route_id() const {
On 2009/12/10 00:09:55, John Abd-El-Malek wrote:
> nit: we usually put small getters like this on one line

Done.

http://codereview.chromium.org/465040/diff/9001/10010#newcode54
chrome/plugin/command_buffer_stub.h:54: PluginChannel* channel_;
On 2009/12/10 00:09:55, John Abd-El-Malek wrote:
> why not scoped_refptr<PluginChannel>?

Done.

http://codereview.chromium.org/465040/diff/9001/10023
File chrome/plugin/webplugin_delegate_stub.cc (right):

http://codereview.chromium.org/465040/diff/9001/10023#newcode363
chrome/plugin/webplugin_delegate_stub.cc:363: *route_id = 0;
On 2009/12/10 00:09:55, John Abd-El-Malek wrote:
> nit: this line seems unnecessary, since if ENABLE_PEPPER isn't defined, the
> message won't be sent.

Done.

http://codereview.chromium.org/465040/diff/9001/10012
File chrome/renderer/command_buffer_proxy.cc (right):

http://codereview.chromium.org/465040/diff/9001/10012#newcode40
chrome/renderer/command_buffer_proxy.cc:40: // is responsible for duplicating
the handle. This might not be true for
On 2009/12/10 00:09:55, John Abd-El-Malek wrote:
> nit "the is"

Done.

http://codereview.chromium.org/465040/diff/9001/10011
File chrome/renderer/command_buffer_proxy.h (right):

http://codereview.chromium.org/465040/diff/9001/10011#newcode64
chrome/renderer/command_buffer_proxy.h:64: PluginChannelHost* channel_;
Done.

http://codereview.chromium.org/465040/diff/9001/10001
File gpu/command_buffer/service/command_buffer_service.h (right):

http://codereview.chromium.org/465040/diff/9001/10001#newcode21
gpu/command_buffer/service/command_buffer_service.h:21: class
CommandBufferService : public CommandBuffer {
All the other classes in the gpu/command_buffer directory are in this namespace
and they don't all have CommandBuffer in their name. Consistency?

http://codereview.chromium.org/465040/diff/9001/10002
File gpu/gpu.gyp (left):

http://codereview.chromium.org/465040/diff/9001/10002#oldcode309
gpu/gpu.gyp:309: 'np_utils/webkit_browser.h',
I deleted them in another CL. gman has it.

http://codereview.chromium.org/465040/diff/9001/10004
File gpu/gpu_plugin/gpu_plugin_object.h (left):

http://codereview.chromium.org/465040/diff/9001/10004#oldcode1
gpu/gpu_plugin/gpu_plugin_object.h:1: // Copyright (c) 2006-2008 The Chromium
Authors. All rights reserved.
It shows up as "D" in my local diff and yes I deleted it.

[jam, 2009-12-10 22:30:52]

http://codereview.chromium.org/465040/diff/9001/10001
File gpu/command_buffer/service/command_buffer_service.h (right):

http://codereview.chromium.org/465040/diff/9001/10001#newcode21
gpu/command_buffer/service/command_buffer_service.h:21: class
CommandBufferService : public CommandBuffer {
On 2009/12/10 22:03:02, apatrick wrote:
> All the other classes in the gpu/command_buffer directory are in this
namespace
> and they don't all have CommandBuffer in their name. Consistency?

I'm not sure what you mean by consistency?  are you asking if the CommandBuffer
in the name should be dropped to match them?

I just asked Darin about this, and he has a good suggestion: use "gpu" as the
namespace for all the files under \gpu.  The reasons are: this matches what we
do for base, net etc (only one namespace for entire top level directory), it's
informative (gpu is more clear to other devs than command_buffer), it's short,
and it avoids the redundancy in this class name and other places.

http://codereview.chromium.org/465040/diff/19001/14051
File chrome/renderer/command_buffer_proxy.h (right):

http://codereview.chromium.org/465040/diff/19001/14051#newcode64
chrome/renderer/command_buffer_proxy.h:64: int instance_id_;
nit: why change this to instance_id?  It should match the same name as what
CommandBufferStub, so either change both or keep it like what it was in patchset
7.

[jam, 2009-12-10 22:31:12]

On 2009/12/10 22:03:02, apatrick wrote:
> I'm running the win trybot again. I think I just issued the job at a bad time.
> Can you check the DEPS changes. I'm not sure if the dependencies on app are
> legit.

Best to double check with bradnelson for the gyp changes

[apatrick_chromium, 2009-12-10 23:50:36]

+bradnelson

Brad, can you review the changes to the gyp files. Thanks.

Renamed command_buffer namespace to gpu.

http://codereview.chromium.org/465040/diff/19001/14051
File chrome/renderer/command_buffer_proxy.h (right):

http://codereview.chromium.org/465040/diff/19001/14051#newcode64
chrome/renderer/command_buffer_proxy.h:64: int instance_id_;
On 2009/12/10 22:30:52, John Abd-El-Malek wrote:

Done.

[jam, 2009-12-11 00:06:02]

lgtm

nit: probably best to leave this to another change, but there's a lot of
redundant "gpu::" in files that are in the gpu namespace.

On Thu, Dec 10, 2009 at 3:50 PM, <apatrick@chromium.org> wrote:

> +bradnelson
>
> Brad, can you review the changes to the gyp files. Thanks.
>
> Renamed command_buffer namespace to gpu.


I see a bunch of ENABLE_PEPPER  have been changed to ENABLE_GPU, is that
intentional?

[apatrick, 2009-12-11 00:13:12]

On Thu, Dec 10, 2009 at 4:05 PM, John Abd-El-Malek <jam@chromium.org> wrote:

> lgtm
>
> nit: probably best to leave this to another change, but there's a lot of
> redundant "gpu::" in files that are in the gpu namespace.
>
> Will do.


> On Thu, Dec 10, 2009 at 3:50 PM, <apatrick@chromium.org> wrote:
>
>> +bradnelson
>>
>> Brad, can you review the changes to the gyp files. Thanks.
>>
>> Renamed command_buffer namespace to gpu.
>
>
> I see a bunch of ENABLE_PEPPER  have been changed to ENABLE_GPU, is that
> intentional?
>
> Yeah sehr changed the name of the macro because pepper is enabled by
default now.

[bradn, 2009-12-11 00:14:08]

gyp changes LG

[scherkus (not reviewing), 2009-12-11 00:16:11]

drive by copyright year nits

http://codereview.chromium.org/465040/diff/16091/16115
File chrome/plugin/webplugin_delegate_stub.h (right):

http://codereview.chromium.org/465040/diff/16091/16115#newcode1
chrome/plugin/webplugin_delegate_stub.h:1: // Copyright (c) 2006-2008 The
Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16174
File gpu/command_buffer/client/gles2_implementation_gen.h (right):

http://codereview.chromium.org/465040/diff/16091/16174#newcode2
gpu/command_buffer/client/gles2_implementation_gen.h:2: // Copyright (c)
2006-2008 The Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16108
File gpu/command_buffer/common/command_buffer.h (right):

http://codereview.chromium.org/465040/diff/16091/16108#newcode1
gpu/command_buffer/common/command_buffer.h:1: // Copyright (c) 2006-2008 The
Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16109
File gpu/command_buffer/common/command_buffer_mock.h (right):

http://codereview.chromium.org/465040/diff/16091/16109#newcode1
gpu/command_buffer/common/command_buffer_mock.h:1: // Copyright (c) 2006-2008
The Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16158
File gpu/command_buffer/common/gles2_cmd_id_test.cc (right):

http://codereview.chromium.org/465040/diff/16091/16158#newcode2
gpu/command_buffer/common/gles2_cmd_id_test.cc:2: // Copyright (c) 2006-2008 The
Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16107
File gpu/command_buffer/service/command_buffer_service.cc (right):

http://codereview.chromium.org/465040/diff/16091/16107#newcode1
gpu/command_buffer/service/command_buffer_service.cc:1: // Copyright (c)
2006-2008 The Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16092
File gpu/command_buffer/service/command_buffer_service.h (right):

http://codereview.chromium.org/465040/diff/16091/16092#newcode1
gpu/command_buffer/service/command_buffer_service.h:1: // Copyright (c)
2006-2008 The Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16106
File gpu/command_buffer/service/command_buffer_service_unittest.cc (right):

http://codereview.chromium.org/465040/diff/16091/16106#newcode1
gpu/command_buffer/service/command_buffer_service_unittest.cc:1: // Copyright
(c) 2006-2008 The Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16132
File gpu/command_buffer/service/gles2_cmd_decoder_validate.h (right):

http://codereview.chromium.org/465040/diff/16091/16132#newcode2
gpu/command_buffer/service/gles2_cmd_decoder_validate.h:2: // Copyright (c)
2006-2008 The Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16147
File gpu/command_buffer/service/gpu_processor.cc (right):

http://codereview.chromium.org/465040/diff/16091/16147#newcode1
gpu/command_buffer/service/gpu_processor.cc:1: // Copyright (c) 2006-2008 The
Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16117
File gpu/command_buffer/service/gpu_processor.h (right):

http://codereview.chromium.org/465040/diff/16091/16117#newcode1
gpu/command_buffer/service/gpu_processor.h:1: // Copyright (c) 2006-2008 The
Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16118
File gpu/command_buffer/service/gpu_processor_mock.h (right):

http://codereview.chromium.org/465040/diff/16091/16118#newcode1
gpu/command_buffer/service/gpu_processor_mock.h:1: // Copyright (c) 2006-2008
The Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16120
File gpu/command_buffer/service/gpu_processor_unittest.cc (right):

http://codereview.chromium.org/465040/diff/16091/16120#newcode1
gpu/command_buffer/service/gpu_processor_unittest.cc:1: // Copyright (c)
2006-2008 The Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16119
File gpu/command_buffer/service/gpu_processor_win.cc (right):

http://codereview.chromium.org/465040/diff/16091/16119#newcode1
gpu/command_buffer/service/gpu_processor_win.cc:1: // Copyright (c) 2006-2008
The Chromium Authors. All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16126
File gpu/gpu_plugin/gpu_plugin.cc (right):

http://codereview.chromium.org/465040/diff/16091/16126#newcode1
gpu/gpu_plugin/gpu_plugin.cc:1: // Copyright (c) 2006-2008 The Chromium Authors.
All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16122
File gpu/gpu_plugin/gpu_plugin.h (right):

http://codereview.chromium.org/465040/diff/16091/16122#newcode1
gpu/gpu_plugin/gpu_plugin.h:1: // Copyright (c) 2006-2008 The Chromium Authors.
All rights reserved.
nit: copyright year

http://codereview.chromium.org/465040/diff/16091/16105
File webkit/glue/plugins/webplugin_delegate_impl.h (right):

http://codereview.chromium.org/465040/diff/16091/16105#newcode1
webkit/glue/plugins/webplugin_delegate_impl.h:1: // Copyright (c) 2006-2008 The
Chromium Authors. All rights reserved.
nit: copyright year

[apatrick, 2009-12-11 01:03:05]

Done.

On Thu, Dec 10, 2009 at 4:16 PM, <scherkus@chromium.org> wrote:

> drive by copyright year nits
>
>
> http://codereview.chromium.org/465040/diff/16091/16115
> File chrome/plugin/webplugin_delegate_stub.h (right):
>
> http://codereview.chromium.org/465040/diff/16091/16115#newcode1
> chrome/plugin/webplugin_delegate_stub.h:1: // Copyright (c) 2006-2008
>
> The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16174
> File gpu/command_buffer/client/gles2_implementation_gen.h (right):
>
> http://codereview.chromium.org/465040/diff/16091/16174#newcode2
> gpu/command_buffer/client/gles2_implementation_gen.h:2: // Copyright (c)
>
> 2006-2008 The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16108
> File gpu/command_buffer/common/command_buffer.h (right):
>
> http://codereview.chromium.org/465040/diff/16091/16108#newcode1
> gpu/command_buffer/common/command_buffer.h:1: // Copyright (c) 2006-2008
>
> The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16109
> File gpu/command_buffer/common/command_buffer_mock.h (right):
>
> http://codereview.chromium.org/465040/diff/16091/16109#newcode1
> gpu/command_buffer/common/command_buffer_mock.h:1: // Copyright (c)
>
> 2006-2008 The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16158
> File gpu/command_buffer/common/gles2_cmd_id_test.cc (right):
>
> http://codereview.chromium.org/465040/diff/16091/16158#newcode2
> gpu/command_buffer/common/gles2_cmd_id_test.cc:2: // Copyright (c)
>
> 2006-2008 The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16107
> File gpu/command_buffer/service/command_buffer_service.cc (right):
>
> http://codereview.chromium.org/465040/diff/16091/16107#newcode1
> gpu/command_buffer/service/command_buffer_service.cc:1: // Copyright (c)
>
> 2006-2008 The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16092
>
> File gpu/command_buffer/service/command_buffer_service.h (right):
>
> http://codereview.chromium.org/465040/diff/16091/16092#newcode1
> gpu/command_buffer/service/command_buffer_service.h:1: // Copyright (c)
>
> 2006-2008 The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16106
> File gpu/command_buffer/service/command_buffer_service_unittest.cc
> (right):
>
> http://codereview.chromium.org/465040/diff/16091/16106#newcode1
> gpu/command_buffer/service/command_buffer_service_unittest.cc:1: //
>
> Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16132
> File gpu/command_buffer/service/gles2_cmd_decoder_validate.h (right):
>
> http://codereview.chromium.org/465040/diff/16091/16132#newcode2
> gpu/command_buffer/service/gles2_cmd_decoder_validate.h:2: // Copyright
>
> (c) 2006-2008 The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16147
> File gpu/command_buffer/service/gpu_processor.cc (right):
>
> http://codereview.chromium.org/465040/diff/16091/16147#newcode1
> gpu/command_buffer/service/gpu_processor.cc:1: // Copyright (c)
>
> 2006-2008 The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16117
> File gpu/command_buffer/service/gpu_processor.h (right):
>
> http://codereview.chromium.org/465040/diff/16091/16117#newcode1
> gpu/command_buffer/service/gpu_processor.h:1: // Copyright (c) 2006-2008
>
> The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16118
> File gpu/command_buffer/service/gpu_processor_mock.h (right):
>
> http://codereview.chromium.org/465040/diff/16091/16118#newcode1
> gpu/command_buffer/service/gpu_processor_mock.h:1: // Copyright (c)
>
> 2006-2008 The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16120
> File gpu/command_buffer/service/gpu_processor_unittest.cc (right):
>
> http://codereview.chromium.org/465040/diff/16091/16120#newcode1
> gpu/command_buffer/service/gpu_processor_unittest.cc:1: // Copyright (c)
>
> 2006-2008 The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16119
> File gpu/command_buffer/service/gpu_processor_win.cc (right):
>
> http://codereview.chromium.org/465040/diff/16091/16119#newcode1
> gpu/command_buffer/service/gpu_processor_win.cc:1: // Copyright (c)
>
> 2006-2008 The Chromium Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16126
> File gpu/gpu_plugin/gpu_plugin.cc (right):
>
> http://codereview.chromium.org/465040/diff/16091/16126#newcode1
> gpu/gpu_plugin/gpu_plugin.cc:1: // Copyright (c) 2006-2008 The Chromium
> Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16122
> File gpu/gpu_plugin/gpu_plugin.h (right):
>
> http://codereview.chromium.org/465040/diff/16091/16122#newcode1
> gpu/gpu_plugin/gpu_plugin.h:1: // Copyright (c) 2006-2008 The Chromium
> Authors. All rights reserved.
> nit: copyright year
>
> http://codereview.chromium.org/465040/diff/16091/16105
> File webkit/glue/plugins/webplugin_delegate_impl.h (right):
>
> http://codereview.chromium.org/465040/diff/16091/16105#newcode1
> webkit/glue/plugins/webplugin_delegate_impl.h:1: // Copyright (c)
>
> 2006-2008 The Chromium Authors. All rights reserved.
> nit: copyright year
>
>
> http://codereview.chromium.org/465040
>

[scherkus (not reviewing), 2009-12-11 01:05:58]

rubber stamp lg -- thanks!