Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 465013: TBR=apatrick@chromium.org... (Closed)

Created:
11 years ago by greggman
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

TBR=apatrick@chromium.org TEST=none BUG=none NOTE: This CL was already reviewed. See: http://codereview.chromium.org/437044/show Add ids and stubs for new common commands and change it so command ids are 11 bits and the size is 21 bits. Since size is in command elements and 1 command element is 4 bytes that allows you to pass 2^23rd bytes inside the command buffer which is 8meg.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+848 lines, -374 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/cmd_buffer_common.h View 6 chunks +423 lines, -20 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_id_test.cc View 1 chunk +176 lines, -176 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +176 lines, -176 lines 0 comments Download
M gpu/command_buffer/service/common_decoder.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698