git watchlists (hook)

git watchlists

[John Grabowski, 2009-12-02 23:27:50]

Hook portion of git watchlists.
See also http://codereview.chromium.org/461001

[Paweł Hajdan Jr., 2009-12-03 07:32:42]

Is this setting a setting always for the master branch? Shouldn't it rather set
it for the current branch?

[chase, 2009-12-03 17:37:28]

On 2009/12/03 07:32:42, Paweł Hajdan Jr. wrote:
> Is this setting a setting always for the master branch? Shouldn't it rather
set
> it for the current branch?

Agreed about current branch.  I'm interested to find out if rietveld.extra_cc
was chosen over the_current_branch.extra_cc?

@jrg: In your patches I see lines like:

  @@ -%ld,%ld +%ld,%ld @@

where the diff section markers should be.  Seems like rietveld doesn't handle
this well.  (Clicking 'view' or the file name for the diff returns 'Can't parse
the patch'; 'download raw patch' gets the original diff without formatting..)

[John Grabowski, 2009-12-03 18:26:13]

This change is now in http://codereview.chromium.org/460038 which has the
correct config name (not specific to a branch, as negotiated with Evan.)

chase: don't know why I'm getting a %ld instead of a number but I'll look
into it.

jrg


On Thu, Dec 3, 2009 at 9:37 AM, <chase@chromium.org> wrote:

> On 2009/12/03 07:32:42, Paweł Hajdan Jr. wrote:
>
>> Is this setting a setting always for the master branch? Shouldn't it
>> rather
>>
> set
>
>> it for the current branch?
>>
>
> Agreed about current branch.  I'm interested to find out if
> rietveld.extra_cc
> was chosen over the_current_branch.extra_cc?
>
> @jrg: In your patches I see lines like:
>
>  @@ -%ld,%ld +%ld,%ld @@
>
> where the diff section markers should be.  Seems like rietveld doesn't
> handle
> this well.  (Clicking 'view' or the file name for the diff returns 'Can't
> parse
> the patch'; 'download raw patch' gets the original diff without
> formatting..)
>
>
> http://codereview.chromium.org/463010
>

[chase, 2009-12-04 20:50:49]

On 2009/12/03 18:26:13, John Grabowski wrote:
> This change is now in http://codereview.chromium.org/460038 which has the
> correct config name (not specific to a branch, as negotiated with Evan.)

I'll mark this as closed.

> chase: don't know why I'm getting a %ld instead of a number but I'll look
> into it.
> 
> jrg
> 
> 
> On Thu, Dec 3, 2009 at 9:37 AM, <mailto:chase@chromium.org> wrote:
> 
> > On 2009/12/03 07:32:42, Paweł Hajdan Jr. wrote:
> >
> >> Is this setting a setting always for the master branch? Shouldn't it
> >> rather
> >>
> > set
> >
> >> it for the current branch?
> >>
> >
> > Agreed about current branch.  I'm interested to find out if
> > rietveld.extra_cc
> > was chosen over the_current_branch.extra_cc?
> >
> > @jrg: In your patches I see lines like:
> >
> >  @@ -%ld,%ld +%ld,%ld @@
> >
> > where the diff section markers should be.  Seems like rietveld doesn't
> > handle
> > this well.  (Clicking 'view' or the file name for the diff returns 'Can't
> > parse
> > the patch'; 'download raw patch' gets the original diff without
> > formatting..)
> >
> >
> > http://codereview.chromium.org/463010
> >
>