Issue 460038: Add watchlist hook for git.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 460038: Add watchlist hook for git. (Closed)

Created:
11 years ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
chase, Evan Martin, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, M-A Ruel

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

Description

Add watchlist hook for git.

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	git_cl_hooks.py	View		3 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

Final diff with data name negotiated with Evan. Original CL for this was http://codereview.chromium.org/463010

11 years ago (2009-12-03 02:44:39 UTC) #1

chase

LGTM. What's the thinking on 'rietveld.extra_cc'? Use it like a scratchpad? (Since it'll be overwritten ...

11 years ago (2009-12-03 19:56:58 UTC) #3

John Grabowski

11 years ago (2009-12-03 20:21:22 UTC) #5

The ideas behind the name are
- not specific to watchlists; is more generic
- does not klobber rietveld.cc which is only set at 'git config'
- does not need to be associated with a branch name
- (yes, like a scratchpad.  Not read other than right after it is written)


jrg

On Thu, Dec 3, 2009 at 11:56 AM, <chase@chromium.org> wrote:

> LGTM.  What's the thinking on 'rietveld.extra_cc'?  Use it like a
> scratchpad?
> (Since it'll be overwritten with each git-cl upload on any branch where the
> Chromium hooks are used..)
>
>
>       patchset = None
>> -    self.change = presubmit_support.GitChange(name, description, absroot,
>>
> files,
>
>> -                                              issue, patchset)
>> +    self.change = presubmit_support.GitChange(name, description, absroot,
>> +                                              files, issue, patchset)
>>
>
> nit: unnecessary?
>
>
> http://codereview.chromium.org/460038
>

Expand Messages | Collapse Messages