|
|
Use factory to create histograms, and refcounts to track lifetimes
This is CL patch 377028 by Raman Tenneti, with minor changes to
make the try-bots happier.
It is cleanup that better ensures lifetimes of histograms (making it harder
for users to abuse them).
bug= 16495
(repairs leak induced by the first landing)
bug= 18840
(should make leaks less possible)
tbr=raman.tenneti
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33933
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+771 lines, -420 lines) |
Patch |
 |
M |
base/histogram.h
|
View
|
1
2
3
4
5
6
7
8
|
18 chunks |
+213 lines, -104 lines |
0 comments
|
Download
|
|
M |
base/histogram.cc
|
View
|
1
2
3
4
5
6
7
8
|
11 chunks |
+191 lines, -69 lines |
0 comments
|
Download
|
|
M |
base/histogram_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
|
5 chunks |
+74 lines, -53 lines |
0 comments
|
Download
|
|
M |
base/message_loop.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
base/message_loop.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chrome_browser_application_mac.mm
|
View
|
5
6
7
8
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/diagnostics/sqlite_diagnostics.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/jankometer.cc
|
View
|
1
2
3
4
5
6
7
8
|
3 chunks |
+12 lines, -10 lines |
0 comments
|
Download
|
|
M |
chrome/browser/net/dns_host_info.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+41 lines, -31 lines |
0 comments
|
Download
|
|
M |
chrome/browser/renderer_host/buffered_resource_handler.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+14 lines, -9 lines |
0 comments
|
Download
|
|
M |
chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ssl/ssl_blocking_page.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_service.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+6 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/renderer/render_thread.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+11 lines, -5 lines |
0 comments
|
Download
|
|
M |
net/base/connection_type_histograms.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+12 lines, -10 lines |
0 comments
|
Download
|
|
M |
net/base/mime_sniffer.cc
|
View
|
1
2
3
4
5
6
7
8
|
12 chunks |
+45 lines, -41 lines |
0 comments
|
Download
|
|
M |
net/base/sdch_manager.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
net/disk_cache/histogram_macros.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
|
M |
net/disk_cache/stats.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/disk_cache/stats.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
net/disk_cache/stats_histogram.h
|
View
|
1
2
3
4
5
6
7
8
|
4 chunks |
+14 lines, -2 lines |
0 comments
|
Download
|
|
M |
net/disk_cache/stats_histogram.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+31 lines, -0 lines |
0 comments
|
Download
|
|
M |
net/ftp/ftp_network_transaction.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+12 lines, -10 lines |
0 comments
|
Download
|
|
M |
net/ftp/ftp_server_type_histograms.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+12 lines, -10 lines |
0 comments
|
Download
|
|
M |
net/http/http_network_transaction.cc
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+28 lines, -21 lines |
0 comments
|
Download
|
|
M |
net/socket_stream/socket_stream_metrics.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+12 lines, -10 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
462027:
Use factory to create histograms, and refcounts to track lifetimes... (Closed)
