Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1585)

Unified Diff: net/ftp/ftp_server_type_histograms.cc

Issue 462027: Use factory to create histograms, and refcounts to track lifetimes... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ftp/ftp_network_transaction.cc ('k') | net/http/http_network_transaction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ftp/ftp_server_type_histograms.cc
===================================================================
--- net/ftp/ftp_server_type_histograms.cc (revision 33932)
+++ net/ftp/ftp_server_type_histograms.cc (working copy)
@@ -22,22 +22,24 @@
// expansion.
void UpdateFtpServerTypeHistograms(FtpServerType type) {
static bool had_server_type[NUM_OF_SERVER_TYPES];
- static LinearHistogram counter1("Net.HadFtpServerType",
- 1, NUM_OF_SERVER_TYPES,
- NUM_OF_SERVER_TYPES + 1);
- static LinearHistogram counter2("Net.FtpServerTypeCount",
- 1, NUM_OF_SERVER_TYPES,
- NUM_OF_SERVER_TYPES + 1);
+ static scoped_refptr<Histogram> counter1 =
+ LinearHistogram::LinearHistogramFactoryGet("Net.HadFtpServerType",
+ 1, NUM_OF_SERVER_TYPES,
+ NUM_OF_SERVER_TYPES + 1);
+ static scoped_refptr<Histogram> counter2 =
+ LinearHistogram::LinearHistogramFactoryGet("Net.FtpServerTypeCount",
+ 1, NUM_OF_SERVER_TYPES,
+ NUM_OF_SERVER_TYPES + 1);
if (type >= 0 && type < NUM_OF_SERVER_TYPES) {
if (!had_server_type[type]) {
had_server_type[type] = true;
- counter1.SetFlags(kUmaTargetedHistogramFlag);
- counter1.Add(type);
+ counter1->SetFlags(kUmaTargetedHistogramFlag);
+ counter1->Add(type);
}
}
- counter2.SetFlags(kUmaTargetedHistogramFlag);
- counter2.Add(type);
+ counter2->SetFlags(kUmaTargetedHistogramFlag);
+ counter2->Add(type);
}
} // namespace net
Property changes on: net\ftp\ftp_server_type_histograms.cc
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « net/ftp/ftp_network_transaction.cc ('k') | net/http/http_network_transaction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698