Use factory to create histograms, and refcounts to track lifetimes...

chrome/browser/jankometer.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits>
 
 #include "chrome/browser/jankometer.h"
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
@@ skipping 73 matching lines @@
 //------------------------------------------------------------------------------
 class JankObserver : public base::RefCountedThreadSafe<JankObserver>,
                      public MessageLoopForUI::Observer {
  public:
   JankObserver(const char* thread_name,
                const TimeDelta& excessive_duration,
                bool watchdog_enable)
       : MaxMessageDelay_(excessive_duration),
         slow_processing_counter_(std::string("Chrome.SlowMsg") + thread_name),
         queueing_delay_counter_(std::string("Chrome.DelayMsg") + thread_name),
-        process_times_((std::string("Chrome.ProcMsgL ") +
-                        thread_name).c_str(), 1, 3600000, 50),
-        total_times_((std::string("Chrome.TotalMsgL ") +
-                      thread_name).c_str(), 1, 3600000, 50),
         total_time_watchdog_(excessive_duration, thread_name, watchdog_enable) {
-    process_times_.SetFlags(kUmaTargetedHistogramFlag);
-    total_times_.SetFlags(kUmaTargetedHistogramFlag);
+    process_times_ = Histogram::HistogramFactoryGet(
+        (std::string("Chrome.ProcMsgL ") + thread_name),
+        1, 3600000, 50);
+    total_times_ = Histogram::HistogramFactoryGet(
+        (std::string("Chrome.TotalMsgL ") + thread_name),
+        1, 3600000, 50);
+    process_times_->SetFlags(kUmaTargetedHistogramFlag);
+    total_times_->SetFlags(kUmaTargetedHistogramFlag);
   }
 
   // Attaches the observer to the current thread's message loop. You can only
   // attach to the current thread, so this function can be invoked on another
   // thread to attach it.
   void AttachToCurrentThread() {
     // TODO(darin): support monitoring jankiness on non-UI threads!
     if (MessageLoop::current()->type() == MessageLoop::TYPE_UI)
       MessageLoopForUI::current()->AddObserver(this);
   }
@@ skipping 19 matching lines @@
     }
   }
 
   // Called when a message has just finished processing, finalizes
   // per-message variables and timers.
   void EndProcessingTimers() {
     total_time_watchdog_.Disarm();
     TimeTicks now = TimeTicks::Now();
     if (begin_process_message_ != TimeTicks()) {
       TimeDelta processing_time = now - begin_process_message_;
-      process_times_.AddTime(processing_time);
-      total_times_.AddTime(queueing_time_ + processing_time);
+      process_times_->AddTime(processing_time);
+      total_times_->AddTime(queueing_time_ + processing_time);
     }
     if (now - begin_process_message_ >
         TimeDelta::FromMilliseconds(kMaxMessageProcessingMs)) {
       // Message took too long to process.
       slow_processing_counter_.Increment();
 #if defined(OS_WIN)
       if (kPlaySounds)
         MessageBeep(MB_ICONHAND);
 #endif
     }
@@ skipping 49 matching lines @@
   // Time at which the current message processing began.
   TimeTicks begin_process_message_;
 
   // Time the current message spent in the queue -- delta between message
   // construction time and message processing time.
   TimeDelta queueing_time_;
 
   // Counters for the two types of jank we measure.
   StatsCounter slow_processing_counter_;  // Messages with long processing time.
   StatsCounter queueing_delay_counter_;   // Messages with long queueing delay.
-  Histogram process_times_;           // Time spent processing task.
-  Histogram total_times_;             // Total of queueing plus processing time.
+  scoped_refptr<Histogram> process_times_;  // Time spent processing task.
+  scoped_refptr<Histogram> total_times_;  // Total queueing plus processing.
   JankWatchdog total_time_watchdog_;  // Watching for excessive total_time.
 
   DISALLOW_EVIL_CONSTRUCTORS(JankObserver);
 };
 
 // These objects are created by InstallJankometer and leaked.
 JankObserver* ui_observer = NULL;
 JankObserver* io_observer = NULL;
 
 }  // namespace
@@ skipping 42 matching lines @@
     ui_observer->Release();
     ui_observer = NULL;
   }
   if (io_observer) {
     // IO thread can't be running when we remove observers.
     DCHECK((!g_browser_process) || !(g_browser_process->io_thread()));
     io_observer->Release();
     io_observer = NULL;
   }
 }