Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 46035: Improve the look of the Linux omnibox. (Closed)

Created:
11 years, 9 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Improve the look of the Linux omnibox. - Paint a border around the input widget, which makes it fit better into the toolbar. A bordered widget is also very nice to have for debugging, so I abstracted a small helper for making a bordered bin. - Improve the results popup by painting with some Pango attributes. Sort of looks awful over NX, but I'm hoping it looks better on a real session. BUG=8236

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -22 lines) Patch
M base/gfx/gtk_util.h View 2 chunks +7 lines, -0 lines 1 comment Download
M base/gfx/gtk_util.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc View 2 chunks +8 lines, -6 lines 1 comment Download
M chrome/browser/gtk/location_bar_view_gtk.h View 2 chunks +8 lines, -4 lines 1 comment Download
M chrome/browser/gtk/location_bar_view_gtk.cc View 4 chunks +31 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dean McNamee
11 years, 9 months ago (2009-03-13 16:10:21 UTC) #1
Evan Martin
11 years, 9 months ago (2009-03-13 16:33:29 UTC) #2
LGTM

http://codereview.chromium.org/46035/diff/1/3
File base/gfx/gtk_util.h (right):

http://codereview.chromium.org/46035/diff/1/3#newcode36
Line 36: int top, int bottom, int left, int right);
I'm a little skeptical we'll use this too often.  We have custom graphic images
for basically everything in this app.

http://codereview.chromium.org/46035/diff/1/4
File chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc (right):

http://codereview.chromium.org/46035/diff/1/4#newcode81
Line 81: g_free (markup);
extra space

http://codereview.chromium.org/46035/diff/1/6
File chrome/browser/gtk/location_bar_view_gtk.h (right):

http://codereview.chromium.org/46035/diff/1/6#newcode68
Line 68: // This is the widget you probably care about, our inner vbox (inside
the
Who is "you" in this case?  The first half of this comment isn't especially
helpful.

Powered by Google App Engine
This is Rietveld 408576698