Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4528)

Unified Diff: chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc

Issue 46035: Improve the look of the Linux omnibox. (Closed)
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
diff --git a/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc b/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
index 94a5cdf6ce98dc66b4f3bc1012b9b43e08e036a5..4cd305f8782c371fa00d10830a1fff4f971687de 100755
--- a/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
+++ b/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc
@@ -41,7 +41,6 @@ AutocompletePopupViewGtk::AutocompletePopupViewGtk(
// Set up a 1 pixel border around the popup.
gtk_container_set_border_width(GTK_CONTAINER(window_), 1);
gtk_widget_modify_bg(window_, GTK_STATE_NORMAL, &kPopupBorderColor);
- gtk_widget_modify_base(window_, GTK_STATE_NORMAL, &kPopupBorderColor);
}
AutocompletePopupViewGtk::~AutocompletePopupViewGtk() {
@@ -73,11 +72,14 @@ void AutocompletePopupViewGtk::UpdatePopupAppearance() {
vbox_ = gtk_vbox_new(FALSE, 0);
for (size_t i = 0; i < result.size(); ++i) {
- std::string utf8;
- utf8.append(WideToUTF8(result.match_at(i).contents));
- utf8.append(" - ");
- utf8.append(WideToUTF8(result.match_at(i).description));
- GtkWidget* label = gtk_label_new(utf8.c_str());
+ GtkWidget* label = gtk_label_new(NULL);
+ char* markup = g_markup_printf_escaped(
+ "%s <span weight=\"light\" size=\"small\">%s</span>",
+ WideToUTF8(result.match_at(i).contents).c_str(),
+ WideToUTF8(result.match_at(i).description).c_str());
+ gtk_label_set_markup(GTK_LABEL(label), markup);
+ g_free (markup);
Evan Martin 2009/03/13 16:33:29 extra space
+
// We need to put the labels in an event box for background painting.
GtkWidget* ebox = gtk_event_box_new();
gtk_misc_set_alignment(GTK_MISC(label), 0, 0);

Powered by Google App Engine
This is Rietveld 408576698