Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: chrome/browser/gtk/location_bar_view_gtk.h

Issue 46035: Improve the look of the Linux omnibox. (Closed)
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/gtk/location_bar_view_gtk.h
diff --git a/chrome/browser/gtk/location_bar_view_gtk.h b/chrome/browser/gtk/location_bar_view_gtk.h
index 67c8fdcdebda44167c03685c4ff392ecdd13f4a8..a2a32089430c633b57dada16fd0d3980ba79b921 100644
--- a/chrome/browser/gtk/location_bar_view_gtk.h
+++ b/chrome/browser/gtk/location_bar_view_gtk.h
@@ -33,9 +33,8 @@ class LocationBarViewGtk : public AutocompleteEditController,
void SetProfile(Profile* profile);
- // Return the native vbox widget. You must call Init() first, or the result
- // will be NULL. This is the widget that an embedder should host.
- GtkWidget* widget() { return vbox_; }
+ // Returns the widget the caller should host. You must call Init() first.
+ GtkWidget* widget() { return outer_bin_; }
// Updates the location bar. We also reset the bar's permanent text and
// security style, and, if |tab_for_state_restoring| is non-NULL, also
@@ -63,7 +62,12 @@ class LocationBarViewGtk : public AutocompleteEditController,
virtual void SaveStateToContents(TabContents* contents);
private:
- GtkWidget* vbox_;
+ // The outermost widget we want to be hosted.
+ GtkWidget* outer_bin_;
+
+ // This is the widget you probably care about, our inner vbox (inside the
Evan Martin 2009/03/13 16:33:29 Who is "you" in this case? The first half of this
+ // the border) which holds the elements inside the location bar.
+ GtkWidget* inner_vbox_;
scoped_ptr<AutocompleteEditViewGtk> location_entry_;

Powered by Google App Engine
This is Rietveld 408576698