Issue 45010: Remove all uses of StringShape variables, since that has proven...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45010: Remove all uses of StringShape variables, since that has proven... (Closed)

Created:
11 years, 9 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove all uses of StringShape variables, since that has proven to be error-prone and of little benefit in terms of performance. Committed: http://code.google.com/p/v8/source/detail?r=1521

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+360 lines, -604 lines)			Patch
M	src/api.cc	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	src/codegen.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/conversions.cc	View	3 chunks	+4 lines, -7 lines	0 comments	Download
M	src/factory.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/factory.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/handles.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/heap.cc	View	9 chunks	+26 lines, -45 lines	0 comments	Download
M	src/interpreter-irregexp.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/jsregexp.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/jsregexp.cc	View	6 chunks	+7 lines, -74 lines	0 comments	Download
M	src/log.cc	View	1 chunk	+7 lines, -9 lines	0 comments	Download
M	src/objects.h	View	8 chunks	+11 lines, -21 lines	0 comments	Download
M	src/objects.cc	View	43 chunks	+96 lines, -138 lines	0 comments	Download
M	src/objects-debug.cc	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	src/objects-inl.h	View	9 chunks	+34 lines, -48 lines	0 comments	Download
M	src/parser.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	src/prettyprinter.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/regexp-macro-assembler-ia32.cc	View	2 chunks	+5 lines, -8 lines	0 comments	Download
M	src/runtime.cc	View	39 chunks	+128 lines, -161 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	10 chunks	+14 lines, -40 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages