test/cctest/test-heap.cc - Issue 45010: Remove all uses of StringShape variables, since that has proven...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap.cc

Issue 45010: Remove all uses of StringShape variables, since that has proven... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-heap.cc

===================================================================

--- test/cctest/test-heap.cc (revision 1519)

+++ test/cctest/test-heap.cc (working copy)

@@ -254,10 +254,9 @@

static void VerifyStringAllocation(const char* string) {

String* s = String::cast(Heap::AllocateStringFromUtf8(CStrVector(string)));

- StringShape shape(s);

- CHECK_EQ(static_cast<int>(strlen(string)), s->length(shape));

- for (int index = 0; index < s->length(shape); index++) {

- CHECK_EQ(static_cast<uint16_t>(string[index]), s->Get(shape, index)); }

+ CHECK_EQ(static_cast<int>(strlen(string)), s->length());

+ for (int index = 0; index < s->length(); index++) {

+ CHECK_EQ(static_cast<uint16_t>(string[index]), s->Get(index)); }

}

« no previous file with comments | « src/runtime.cc ('k') | test/cctest/test-regexp.cc » ('j') | no next file with comments »