src/interpreter-irregexp.cc - Issue 45010: Remove all uses of StringShape variables, since that has proven...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter-irregexp.cc

Issue 45010: Remove all uses of StringShape variables, since that has proven... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter-irregexp.cc

===================================================================

--- src/interpreter-irregexp.cc (revision 1519)

+++ src/interpreter-irregexp.cc (working copy)

@@ -569,13 +569,12 @@

Handle<String> subject,

int* registers,

int start_position) {

- ASSERT(subject->IsFlat(StringShape(*subject)));

+ ASSERT(subject->IsFlat());

AssertNoAllocation a;

const byte* code_base = code_array->GetDataStartAddress();

- StringShape subject_shape(*subject);

uc16 previous_char = '\n';

- if (subject_shape.IsAsciiRepresentation()) {

+ if (StringShape(*subject).IsAsciiRepresentation()) {

Vector<const char> subject_vector = subject->ToAsciiVector();

if (start_position != 0) previous_char = subject_vector[start_position - 1];

return RawMatch(code_base,

« no previous file with comments | « src/heap.cc ('k') | src/jsregexp.h » ('j') | no next file with comments »