Issue 443011: Refactor OS-dependent filename exclusion patterns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 443011: Refactor OS-dependent filename exclusion patterns (Closed)

Created:
11 years ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Refactor OS-dependent filename exclusion patterns Rather than duplicate logic in the tree, merge all of the shared rules about patterns in filenames into one common set. The pattern is: "if (OS != x): exclude x's files." This is especially needed for upcoming changes that bring in a few more platform-specific (FreeBSD, OpenBSD, Solaris(?)) files. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33160

Patch Set 1 #

Patch Set 2 : cleanups #

Total comments: 2

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -92 lines)			Patch
M	app/app.gyp	View	1	1 chunk	+0 lines, -27 lines	0 comments	Download
M	base/base.gyp	View		6 chunks	+1 line, -34 lines	0 comments	Download
	build/common.gypi	View	1	2 chunks	+33 lines, -1 line	2 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+0 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years ago (2009-11-26 05:54:07 UTC) #3

LGTM

http://codereview.chromium.org/443011/diff/1001/2003
File build/common.gypi (right):

http://codereview.chromium.org/443011/diff/1001/2003#newcode927
build/common.gypi:927: ['exclude', '/win_[^/]*\\.cc$'] ],
I would have turned the * into a + here and on line 937.

http://codereview.chromium.org/443011/diff/1001/2003#newcode930
build/common.gypi:930: 'sources/': [ ['exclude',
'_(cocoa|mac)(_unittest)?\\.cc$'],
I'm surprised the exclude for '/cocoa/' (directories named cocoa) is missing.  I
guess everything in that directory is an .mm file?

Expand Messages | Collapse Messages