Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: app/app.gyp

Issue 443011: Refactor OS-dependent filename exclusion patterns (Closed)
Patch Set: cleanups Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base.gyp » ('j') | build/common.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/app.gyp
diff --git a/app/app.gyp b/app/app.gyp
index fbc9e2d6ac6187333d7235333d2cf141eda30d72..78f9978b60e8b224ccafb95a4d40a00f069d1eb4 100644
--- a/app/app.gyp
+++ b/app/app.gyp
@@ -15,33 +15,6 @@
'resources/app_strings.grd',
],
},
- 'target_defaults': {
- 'sources/': [
- ['exclude', '/(cocoa|gtk|win)/'],
- ['exclude', '_(cocoa|gtk|linux|mac|posix|skia|win|x)\\.(cc|mm?)$'],
- ['exclude', '/(gtk|win|x11)_[^/]*\\.cc$'],
- ],
- 'conditions': [
- ['OS=="linux"', {'sources/': [
- ['include', '/gtk/'],
- ['include', '_(gtk|linux|posix|skia|x)\\.cc$'],
- ['include', '/(gtk|x11)_[^/]*\\.cc$'],
- ]}],
- ['OS=="mac"', {'sources/': [
- ['include', '/cocoa/'],
- ['include', '_(cocoa|mac|posix)\\.(cc|mm?)$'],
- ]}, { # else: OS != "mac"
- 'sources/': [
- ['exclude', '\\.mm?$'],
- ],
- }],
- ['OS=="win"', {'sources/': [
- ['include', '_(win)\\.cc$'],
- ['include', '/win/'],
- ['include', '/win_[^/]*\\.cc$'],
- ]}],
- ],
- },
'targets': [
{
'target_name': 'app_base',
« no previous file with comments | « no previous file | base/base.gyp » ('j') | build/common.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698