Refactor OS-dependent filename exclusion patterns

build/common.gypi

 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   'variables': {
     # .gyp files should set chromium_code to 1 if they build Chromium-specific
@@ skipping 890 matching lines @@
             'ProxyFileName': '$(InputName)_p.c',
           },
           'VCResourceCompilerTool': {
             'Culture' : '1033',
             'AdditionalIncludeDirectories': ['<(DEPTH)'],
           },
         },
       },
     }],
     ['chromium_code==0', {
-      # This section must follow the other conditon sections above because
+      # This section must follow the other condition sections above because
       # external_code.gypi expects to be merged into those settings.
       'includes': [
         'external_code.gypi',
       ],
     }, {
       'target_defaults': {
         # In Chromium code, we define __STDC_FORMAT_MACROS in order to get the
         # C99 macros on Mac and Linux.
         'defines': [
           '__STDC_FORMAT_MACROS',
         ],
+        'conditions': [
+          ['OS!="win"', {
+            'sources/': [ ['exclude', '_win\\.cc$'],
+                          ['exclude', '/win/'],
+                          ['exclude', '/win_[^/]*\\.cc$'] ],

[Mark Mentovai, 2009/11/26 05:54:07]

I would have turned the * into a + here and on line 937.

+          }],
+          ['OS!="mac"', {
+            'sources/': [ ['exclude', '_(cocoa|mac)(_unittest)?\\.cc$'],

[Mark Mentovai, 2009/11/26 05:54:07]

I'm surprised the exclude for '/cocoa/' (directories named cocoa) is missing.  I
guess everything in that directory is an .mm file?

+                          ['exclude', '\.mm$' ] ],
+          }],
+          ['OS!="linux"', {
+            'sources/': [
+              ['exclude', '_(chromeos|gtk|linux|x|x11)(_unittest)?\\.cc$'],
+              ['exclude', '/gtk/'],
+              ['exclude', '/(gtk|x11)_[^/]*\\.cc$'] ],
+          }],
+          # We use "POSIX" to refer to all non-Windows operating systems.
+          ['OS=="win"', {
+            'sources/': [ ['exclude', '_posix\\.cc$'] ],
+          }],
+          # Though Skia is conceptually shared by Linux and Windows,
+          # the only _skia files in our tree are Linux-specific.
+          ['OS!="linux"', {
+            'sources/': [ ['exclude', '_skia\\.cc$'] ],
+          }],
+          ['chromeos!=1', {
+            'sources/': [ ['exclude', '_chromeos\\.cc$'] ]
+          }],
+          ['OS!="win" and toolkit_views!=1', {
+            'sources/': [ ['exclude', '_views\\.cc$'] ]
+          }],
+        ],
       },
     }],
     ['disable_nacl==1', {
       'target_defaults': {
         'defines': [
           'DISABLE_NACL',
         ],
       },
     }],
     ['msvs_use_common_linker_extras', {
@@ skipping 41 matching lines @@
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }
 
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: