Issue 4321006: Disable the remaining pylint warnings locally and enable pylint warnings in PRESUBMIT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4321006: Disable the remaining pylint warnings locally and enable pylint warnings in PRESUBMIT. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Disable the remaining pylint warnings locally and enable pylint warnings in PRESUBMIT. This causes some code clutter. TEST=Increased pylint warning level BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64913

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -9 lines)			Patch
M	PRESUBMIT.py	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	breakpad.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	gcl.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	gclient.py	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	gclient_utils.py	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	presubmit_canned_checks.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	presubmit_support.py	View	7 chunks	+14 lines, -2 lines	0 comments	Download
M	pylintrc	View	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

It's a bit noisy to my taste so I'm not sure what's the best here ...

10 years, 1 month ago (2010-11-03 14:32:53 UTC) #1

jochen (gone - plz use gerrit)

10 years, 1 month ago (2010-11-03 14:38:38 UTC) #2

On 2010/11/03 14:32:53, Marc-Antoine Ruel wrote:
> It's a bit noisy to my taste so I'm not sure what's the best here but I'd
still
> like to enable warnings and keep most of them enabled by default.
> 
> The PRESUBMIT.py was simply forgotten from the previous change.
lgtm

Expand Messages | Collapse Messages