Disable the remaining pylint warnings locally and enable pylint warnings in PRESUBMIT.

presubmit_support.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.3.5'
 
@@ skipping 23 matching lines @@
 import urllib2  # Exposed through the API.
 from warnings import warn
 
 try:
   import simplejson as json
 except ImportError:
   try:
     import json
     # Some versions of python2.5 have an incomplete json module.  Check to make
     # sure loads exists.
+    # Statement seems to have no effect
+    # pylint: disable=W0104
     json.loads
   except (ImportError, AttributeError):
     # Import the one included in depot_tools.
     sys.path.append(os.path.join(os.path.dirname(__file__), 'third_party'))
     import simplejson as json
 
 # Local imports.
 import gclient_utils
 import presubmit_canned_checks
 import scm
@@ skipping 34 matching lines @@
     line_number = 0
     for line in lines:
       line_number += 1
       yield (af, line_number, line)
 
 
 class OutputApi(object):
   """This class (more like a module) gets passed to presubmit scripts so that
   they can specify various types of results.
   """
-
+  # Method could be a function
+  # pylint: disable=R0201
   class PresubmitResult(object):
     """Base class for result objects."""
 
     def __init__(self, message, items=None, long_text=''):
       """
       message: A short one-line message to indicate errors.
       items: A list of short strings to indicate where errors occurred.
       long_text: multi-line text output, e.g. from another tool
       """
       self._message = message
@@ skipping 61 matching lines @@
     """A warning that should be included in the review request email."""
     def __init__(self, *args, **kwargs):
       super(OutputApi.MailTextResult, self).__init__()
       raise NotImplementedException()
 
 
 class InputApi(object):
   """An instance of this object is passed to presubmit scripts so they can
   know stuff about the change they're looking at.
   """
+  # Method could be a function
+  # pylint: disable=R0201
 
   # File extensions that are considered source files from a style guide
   # perspective. Don't modify this list from a presubmit script!
   DEFAULT_WHITE_LIST = (
       # C++ and friends
       r".*\.c$", r".*\.cc$", r".*\.cpp$", r".*\.h$", r".*\.m$", r".*\.mm$",
       r".*\.inl$", r".*\.asm$", r".*\.hxx$", r".*\.hpp$",
       # Scripts
       r".*\.js$", r".*\.py$", r".*\.sh$", r".*\.rb$", r".*\.pl$", r".*\.pm$",
       # No extension at all, note that ALL CAPS files are black listed in
@@ skipping 195 matching lines @@
     """
     if isinstance(file_item, AffectedFile):
       file_item = file_item.AbsoluteLocalPath()
     if not file_item.startswith(self.change.RepositoryRoot()):
       raise IOError('Access outside the repository root is denied.')
     return gclient_utils.FileRead(file_item, mode)
 
 
 class AffectedFile(object):
   """Representation of a file in a change."""
-
+  # Method could be a function
+  # pylint: disable=R0201
   def __init__(self, path, action, repository_root=''):
     self._path = path
     self._action = action
     self._local_root = repository_root
     self._is_directory = None
     self._properties = {}
 
   def ServerPath(self):
     """Returns a path string that identifies the file in the SCM system.
 
@@ skipping 67 matching lines @@
     modify this file.
     """
     raise NotImplementedError()  # Implement if/when needed.
 
   def __str__(self):
     return self.LocalPath()
 
 
 class SvnAffectedFile(AffectedFile):
   """Representation of a file in a change out of a Subversion checkout."""
+  # Method 'NNN' is abstract in class 'NNN' but is not overridden
+  # pylint: disable=W0223
 
   def __init__(self, *args, **kwargs):
     AffectedFile.__init__(self, *args, **kwargs)
     self._server_path = None
     self._is_text_file = None
 
   def ServerPath(self):
     if self._server_path is None:
       self._server_path = scm.SVN.CaptureInfo(
           self.AbsoluteLocalPath()).get('URL', '')
@@ skipping 26 matching lines @@
         self._is_text_file = False
       else:
         mime_type = scm.SVN.GetFileProperty(self.AbsoluteLocalPath(),
                                             'svn:mime-type')
         self._is_text_file = (not mime_type or mime_type.startswith('text/'))
     return self._is_text_file
 
 
 class GitAffectedFile(AffectedFile):
   """Representation of a file in a change out of a git checkout."""
+  # Method 'NNN' is abstract in class 'NNN' but is not overridden
+  # pylint: disable=W0223
 
   def __init__(self, *args, **kwargs):
     AffectedFile.__init__(self, *args, **kwargs)
     self._server_path = None
     self._is_text_file = None
 
   def ServerPath(self):
     if self._server_path is None:
       raise NotImplementedException()  # TODO(maruel) Implement.
     return self._server_path
@@ skipping 450 matching lines @@
     else:
       errors.append(result)
 
   error_count = 0
   for name, items in (('Messages', notifications),
                       ('Warnings', warnings),
                       ('ERRORS', errors)):
     if items:
       output_stream.write('** Presubmit %s **\n' % name)
       for item in items:
+        # Access to a protected member XXX of a client class
+        # pylint: disable=W0212
         if not item._Handle(output_stream, input_stream,
                             may_prompt=False):
           error_count += 1
         output_stream.write('\n')
 
   total_time = time.time() - start_time
   if total_time > 1.0:
     print "Presubmit checks took %.1fs to calculate." % total_time
 
   if not errors and warnings and may_prompt:
@@ skipping 91 matching lines @@
                                options.commit,
                                options.verbose,
                                sys.stdout,
                                sys.stdin,
                                options.default_presubmit,
                                options.may_prompt)
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))