Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: PRESUBMIT.py

Issue 4321006: Disable the remaining pylint warnings locally and enable pylint warnings in PRESUBMIT. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | breakpad.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 5d3c9b352534ab44979393d93e5cd03489c96548..9531deee314e75749c6dbffcec873a9a0817bf68 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -57,17 +57,17 @@ def RunPylint(input_api, output_api):
# It uses non-standard pylint exceptions that makes pylint always fail.
files.remove('cpplint.py')
try:
- proc = input_api.subprocess.Popen(['pylint', '-E'] + sorted(files))
+ proc = input_api.subprocess.Popen(['pylint'] + sorted(files))
proc.communicate()
if proc.returncode:
return [output_api.PresubmitError('Fix pylint errors first.')]
return []
- except OSError, e:
+ except OSError:
if input_api.platform == 'win32':
- return [output_api.PresubmitNotifyResult(
- 'Warning: Can\'t run pylint because it is not installed. Please '
- 'install manually\n'
- 'Cannot do static analysis of python files.')]
+ return [output_api.PresubmitNotifyResult(
+ 'Warning: Can\'t run pylint because it is not installed. Please '
+ 'install manually\n'
+ 'Cannot do static analysis of python files.')]
return [output_api.PresubmitError(
'Please install pylint with "sudo apt-get install python-setuptools; '
'sudo easy_install pylint"\n'
« no previous file with comments | « no previous file | breakpad.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698