Chromium Code Reviews

Issue 42638: In the IA32 code genrator, handle call ICs and constructor calls the... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

In the IA32 code genrator, handle call ICs and constructor calls the same as load and store ICs. Eliminate the general function used to call any IC. Committed: http://code.google.com/p/v8/source/detail?r=1619

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+126 lines, -157 lines)
M src/codegen-ia32.cc View 4 chunks +10 lines, -40 lines 0 comments
M src/virtual-frame.cc View 1 chunk +9 lines, -40 lines 0 comments
M src/virtual-frame-arm.h View 2 chunks +7 lines, -10 lines 0 comments
M src/virtual-frame-arm.cc View 4 chunks +36 lines, -11 lines 0 comments
M src/virtual-frame-ia32.h View 3 chunks +18 lines, -22 lines 0 comments
M src/virtual-frame-ia32.cc View 4 chunks +46 lines, -34 lines 0 comments

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
Second part of function call cleanup. The generated code might be improved here by the ...
11 years, 9 months ago (2009-03-26 09:22:06 UTC) #1
William Hesse
11 years, 9 months ago (2009-03-26 10:52:52 UTC) #2
LGTM.  Much simpler.

Powered by Google App Engine