Issue 42635: Lots of files touched for a very simple change. Everywhere we used a const M...

Issue 42635: Lots of files touched for a very simple change. Everywhere we used a const M... (Closed)

Created:
11 years, 9 months ago by ralphl

Modified:
9 years, 7 months ago

Reviewers:
scherkus (not reviewing), fbarchard, Alpha Left Google

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Lots of files touched for a very simple change. Everywhere we used a const MediaFormat* we now use a const MediaFormat&. This makes for simpler code and for better pointer reference safety.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -122 lines)			Patch
M	chrome/renderer/media/audio_renderer_impl.h	View	1 2 3	4 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/renderer/media/audio_renderer_impl.cc	View	1 2 3	2 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/renderer/media/data_source_impl.h	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/renderer/media/data_source_impl.cc	View	1 2 3	3 chunks	+8 lines, -8 lines	0 comments	Download
M	media/base/factory.h	View	1 2 3	7 chunks	+7 lines, -7 lines	0 comments	Download
M	media/base/filters.h	View	1 2 3	6 chunks	+8 lines, -8 lines	0 comments	Download
M	media/base/mock_media_filters.h	View	1 2 3	8 chunks	+12 lines, -12 lines	0 comments	Download
M	media/base/pipeline_impl.h	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/base/pipeline_impl.cc	View	1 2 3	3 chunks	+5 lines, -6 lines	0 comments	Download
M	media/filters/audio_renderer_base.h	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	media/filters/audio_renderer_base.cc	View	1 2 3	2 chunks	+6 lines, -6 lines	0 comments	Download
M	media/filters/audio_renderer_impl.h	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/filters/audio_renderer_impl.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/filters/decoder_base.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/ffmpeg_audio_decoder.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/ffmpeg_audio_decoder.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/ffmpeg_demuxer.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/ffmpeg_demuxer.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer_unittest.cc	View	1 2 3	9 chunks	+25 lines, -19 lines	0 comments	Download
M	media/filters/ffmpeg_video_decoder.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/ffmpeg_video_decoder.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/file_data_source.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/file_data_source.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/filters/file_data_source_unittest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/null_audio_renderer.h	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/filters/null_audio_renderer.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/filters/test_video_decoder.h	View	1 2 3	2 chunks	+6 lines, -6 lines	0 comments	Download
M	media/filters/test_video_renderer.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/video_renderer_base.h	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/filters/video_renderer_base.cc	View	1 2 3	2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ralphl

The 2nd in several installments of pipeline interface updates. This one makes all const MediaFormat* ...

11 years, 9 months ago (2009-03-26 05:14:22 UTC) #1

scherkus (not reviewing)

11 years, 9 months ago (2009-03-26 17:44:10 UTC) #2

LGTM!

http://codereview.chromium.org/42635/diff/1069/60
File chrome/renderer/media/audio_renderer_impl.h (right):

http://codereview.chromium.org/42635/diff/1069/60#newcode135
Line 135: // These methods are called fr&om AudioRendererBase.
I think a & slipped in here :)

Expand Messages | Collapse Messages