Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: media/filters/audio_renderer_base.cc

Issue 42635: Lots of files touched for a very simple change. Everywhere we used a const M... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/audio_renderer_base.h ('k') | media/filters/audio_renderer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/audio_renderer_base.cc
===================================================================
--- media/filters/audio_renderer_base.cc (revision 12568)
+++ media/filters/audio_renderer_base.cc (working copy)
@@ -52,7 +52,7 @@
}
// Defer initialization until all scheduled reads have completed.
- return OnInitialize(decoder_->GetMediaFormat());
+ return OnInitialize(decoder_->media_format());
}
void AudioRendererBase::OnAssignment(Buffer* buffer_in) {
@@ -138,16 +138,16 @@
}
// static
-bool AudioRendererBase::ParseMediaFormat(const MediaFormat* media_format,
+bool AudioRendererBase::ParseMediaFormat(const MediaFormat& media_format,
int* channels_out,
int* sample_rate_out,
int* sample_bits_out) {
// TODO(scherkus): might be handy to support NULL parameters.
std::string mime_type;
- return media_format->GetAsString(MediaFormat::kMimeType, &mime_type) &&
- media_format->GetAsInteger(MediaFormat::kChannels, channels_out) &&
- media_format->GetAsInteger(MediaFormat::kSampleRate, sample_rate_out) &&
- media_format->GetAsInteger(MediaFormat::kSampleBits, sample_bits_out) &&
+ return media_format.GetAsString(MediaFormat::kMimeType, &mime_type) &&
+ media_format.GetAsInteger(MediaFormat::kChannels, channels_out) &&
+ media_format.GetAsInteger(MediaFormat::kSampleRate, sample_rate_out) &&
+ media_format.GetAsInteger(MediaFormat::kSampleBits, sample_bits_out) &&
mime_type.compare(mime_type::kUncompressedAudio) == 0;
}
« no previous file with comments | « media/filters/audio_renderer_base.h ('k') | media/filters/audio_renderer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698