Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: media/filters/audio_renderer_base.h

Issue 42635: Lots of files touched for a very simple change. Everywhere we used a const M... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/pipeline_impl.cc ('k') | media/filters/audio_renderer_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/audio_renderer_base.h
===================================================================
--- media/filters/audio_renderer_base.h (revision 12568)
+++ media/filters/audio_renderer_base.h (working copy)
@@ -43,13 +43,13 @@
static const size_t kDefaultMaxQueueSize;
// Only allow a factory to create this class.
- AudioRendererBase(size_t max_queue_size);
+ explicit AudioRendererBase(size_t max_queue_size);
virtual ~AudioRendererBase();
// Called by Initialize(). |media_format| is the format of the AudioDecoder.
// Subclasses should return true if they were able to initialize, false
// otherwise.
- virtual bool OnInitialize(const MediaFormat* media_format) = 0;
+ virtual bool OnInitialize(const MediaFormat& media_format) = 0;
// Called by Stop(). Subclasses should perform any necessary cleanup during
// this time, such as stopping any running threads.
@@ -70,7 +70,7 @@
// Helper to parse a media format and return whether we were successful
// retrieving all the information we care about.
- static bool ParseMediaFormat(const MediaFormat* media_format,
+ static bool ParseMediaFormat(const MediaFormat& media_format,
int* channels_out, int* sample_rate_out,
int* sample_bits_out);
« no previous file with comments | « media/base/pipeline_impl.cc ('k') | media/filters/audio_renderer_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698