Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 42625: Enable 3 webkit layout tests (Closed)

Created:
11 years, 9 months ago by Alpha Left Google
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enabled tests: LayoutTests/fast/block/float/crash-on-absolute-positioning.html I upstreamed new results to WebKit in r41874: http://trac.webkit.org/changeset/41874 LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-post.html Crash is fixed in CL: http://codereview.chromium.org/50077. Further failure is fixed in CL: http://codereview.chromium.org/53070 LayoutTests/http/tests/xmlhttprequest/simple-cross-origin-progress-events.html First timeout was fixed in http://codereview.chromium.org/53070 This test is still time consuming in nature, it barely finishes in 10s. If we can set timeout to 20s for this test we can fully enable it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12527

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 1 2 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alpha Left Google
11 years, 9 months ago (2009-03-25 22:50:32 UTC) #1
Pam (message me for reviews)
One of these days maybe we'll implement per-test timeouts. (That would only help a handful ...
11 years, 9 months ago (2009-03-25 22:59:45 UTC) #2
Alpha Left Google
On 2009/03/25 22:59:45, Pam wrote: > One of these days maybe we'll implement per-test timeouts. ...
11 years, 9 months ago (2009-03-25 23:19:54 UTC) #3
Pam (message me for reviews)
11 years, 9 months ago (2009-03-26 00:07:31 UTC) #4
On 2009/03/25 23:19:54, Alpha wrote:
> On 2009/03/25 22:59:45, Pam wrote:
> > One of these days maybe we'll implement per-test timeouts. (That would only
> help
> > a handful of tests, so it's not very high priority.) In the meantime, can we
> > mark the TIMEOUT for that one test as DEBUG only, or does it sometimes time
> out
> > in Release too?
> 
> It constantly passes in my machine, I'll enable it to see if it would fail in
> buildbot.


OK, LGTM.

- Pam

Powered by Google App Engine
This is Rietveld 408576698