Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 50077: Fix a layout test crash caused by simple_resource_loader_bridge.cc (Closed)

Created:
11 years, 9 months ago by Alpha Left Google
Modified:
9 years, 6 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixed the following layout test: LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-post.html The crash happens in simple_resource_loader_bridge.cc, there is a case when MaybeUpdateUploadProgress is posted as a task and in the queue while a redirect response by the server cancels the upload. Leaving request_->get_upload() returns NULL, and of cource using of the pointer failes.

Patch Set 1 #

Total comments: 1

Patch Set 2 : stop timer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alpha Left Google
11 years, 9 months ago (2009-03-20 22:35:19 UTC) #1
jcampan
http://codereview.chromium.org/50077/diff/1/2 File webkit/tools/test_shell/simple_resource_loader_bridge.cc (right): http://codereview.chromium.org/50077/diff/1/2#newcode325 Line 325: if (!request_->has_upload()) We should probably stop the upload_progress_timer_ ...
11 years, 9 months ago (2009-03-23 17:58:25 UTC) #2
Alpha Left Google
On 2009/03/23 17:58:25, jcampan wrote: > http://codereview.chromium.org/50077/diff/1/2 > File webkit/tools/test_shell/simple_resource_loader_bridge.cc (right): > > http://codereview.chromium.org/50077/diff/1/2#newcode325 > ...
11 years, 9 months ago (2009-03-24 02:39:47 UTC) #3
jcampan
11 years, 9 months ago (2009-03-24 16:47:08 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698