Issue 53070: Should generate server.upload-dirs in lighttpd.conf...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 53070: Should generate server.upload-dirs in lighttpd.conf... (Closed)

Created:
11 years, 9 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Should generate server.upload-dirs in lighttpd.conf server.upload-dirs field is not in lighttpd.conf, failure some layout tests that do POST. Without that path, Lighttpd fails to save upload data and return HTTP response 413. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12504

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	webkit/tools/layout_tests/layout_package/http_server.py	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

tony

11 years, 9 months ago (2009-03-25 21:27:31 UTC) #1

LGTM

http://codereview.chromium.org/53070/diff/1/2
File webkit/tools/layout_tests/layout_package/http_server.py (right):

http://codereview.chromium.org/53070/diff/1/2#newcode118
Line 118: # Setup upload folders
Nit: Can you mention that this is for http POST messages in the comment?

Expand Messages | Collapse Messages