Issue 42389: Remove a bunch of unnecessary includes from header files in favor of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42389: Remove a bunch of unnecessary includes from header files in favor of... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Remove a bunch of unnecessary includes from header files in favor of forward declarations. Committed: http://code.google.com/p/v8/source/detail?r=1559

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -118 lines)			Patch
M	src/codegen.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/codegen-arm.h	View	5 chunks	+6 lines, -46 lines	0 comments	Download
M	src/codegen-arm.cc	View	5 chunks	+59 lines, -1 line	0 comments	Download
M	src/codegen-ia32.h	View	5 chunks	+5 lines, -58 lines	0 comments	Download
M	src/codegen-ia32.cc	View	3 chunks	+34 lines, -1 line	0 comments	Download
M	src/codegen-inl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/jump-target.h	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/jump-target.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/jump-target-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/jump-target-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/register-allocator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/register-allocator-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/virtual-frame.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/virtual-frame-arm.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/virtual-frame-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/virtual-frame-ia32.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/virtual-frame-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Chromium)

This change moves a bunch of includes out of .h files and into .cc files. ...

11 years, 9 months ago (2009-03-19 13:12:07 UTC) #1

LGTM