Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 42330: Add a close method to sockets (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Add a close method to sockets. Now the destructor is not the only way of closing a socket, which was a bit to limited. Committed: http://code.google.com/p/v8/source/detail?r=1535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -27 lines) Patch
M src/platform.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/platform-freebsd.cc View 3 chunks +14 lines, -7 lines 0 comments Download
M src/platform-linux.cc View 3 chunks +15 lines, -7 lines 0 comments Download
M src/platform-macos.cc View 3 chunks +15 lines, -7 lines 0 comments Download
M src/platform-win32.cc View 3 chunks +15 lines, -6 lines 0 comments Download
M test/cctest/test-sockets.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-18 13:01:48 UTC) #1
Erik Corry
11 years, 9 months ago (2009-03-18 13:06:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698