Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 42233: Add unit tests for DevToolsManager (Closed)

Created:
11 years, 9 months ago by yurys
Modified:
9 years, 7 months ago
Reviewers:
brettw, pfeldman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Initial unit tests implementation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11855

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -13 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_manager.h View 1 4 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_manager.cc View 1 7 chunks +19 lines, -11 lines 0 comments Download
A chrome/browser/debugger/devtools_manager_unittest.cc View 1 2 3 1 chunk +110 lines, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_window.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/unit/unit_tests.scons View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/unit/unittests.vcproj View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
11 years, 9 months ago (2009-03-16 17:45:14 UTC) #1
brettw
Thanks for the test! LGTM http://codereview.chromium.org/42233/diff/1/6 File chrome/browser/debugger/devtools_manager.h (right): http://codereview.chromium.org/42233/diff/1/6#newcode50 Line 50: DevToolsWindow* CreateDevToolsWindow(DevToolsInstanceDescriptor* descriptor); ...
11 years, 9 months ago (2009-03-16 18:26:19 UTC) #2
yurys
11 years, 9 months ago (2009-03-17 11:02:44 UTC) #3
http://codereview.chromium.org/42233/diff/1/6
File chrome/browser/debugger/devtools_manager.h (right):

http://codereview.chromium.org/42233/diff/1/6#newcode50
Line 50: DevToolsWindow* CreateDevToolsWindow(DevToolsInstanceDescriptor*
descriptor);
On 2009/03/16 18:26:19, brettw wrote:
> Can you write a comment for this? Especially note that this should be used
> instead of calling anything manually since it uses the factory.

Done.

Powered by Google App Engine
This is Rietveld 408576698