Issue 42233: Add unit tests for DevToolsManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42233: Add unit tests for DevToolsManager (Closed)

Created:
11 years, 9 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
brettw, pfeldman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Initial unit tests implementation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11855

Patch Set 4 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -13 lines)			Patch
M	chrome/browser/browser_process_impl.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/debugger/devtools_manager.h	View	1	4 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/browser/debugger/devtools_manager.cc	View	1	7 chunks	+19 lines, -11 lines	0 comments	Download
A	chrome/browser/debugger/devtools_manager_unittest.cc	View	1 2 3	1 chunk	+110 lines, -0 lines	0 comments	Download
M	chrome/browser/debugger/devtools_window.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/unit/unit_tests.scons	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/unit/unittests.vcproj	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

Thanks for the test! LGTM http://codereview.chromium.org/42233/diff/1/6 File chrome/browser/debugger/devtools_manager.h (right): http://codereview.chromium.org/42233/diff/1/6#newcode50 Line 50: DevToolsWindow* CreateDevToolsWindow(DevToolsInstanceDescriptor* descriptor); ...

11 years, 9 months ago (2009-03-16 18:26:19 UTC) #2

yurys

11 years, 9 months ago (2009-03-17 11:02:44 UTC) #3

http://codereview.chromium.org/42233/diff/1/6
File chrome/browser/debugger/devtools_manager.h (right):

http://codereview.chromium.org/42233/diff/1/6#newcode50
Line 50: DevToolsWindow* CreateDevToolsWindow(DevToolsInstanceDescriptor*
descriptor);
On 2009/03/16 18:26:19, brettw wrote:
> Can you write a comment for this? Especially note that this should be used
> instead of calling anything manually since it uses the factory.

Done.

Expand Messages | Collapse Messages

Issue 42233: Add unit tests for DevToolsManager (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages