Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chrome/browser/debugger/devtools_manager.h

Issue 42233: Add unit tests for DevToolsManager (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/debugger/devtools_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/debugger/devtools_manager.h
===================================================================
--- chrome/browser/debugger/devtools_manager.h (revision 11854)
+++ chrome/browser/debugger/devtools_manager.h (working copy)
@@ -15,8 +15,10 @@
class Message;
}
+class DevToolsInstanceDescriptor;
class DevToolsInstanceDescriptorImpl;
class DevToolsWindow;
+class DevToolsWindowFactory;
class NavigationController;
class NotificationRegistrar;
class RenderViewHost;
@@ -26,7 +28,9 @@
// messages between developer tools clients and agents.
class DevToolsManager : public NotificationObserver {
public:
- DevToolsManager();
+ // If the factory is NULL, this will create DevToolsWindow objects using
+ // DevToolsWindow::Create static method.
+ DevToolsManager(DevToolsWindowFactory* factory);
virtual ~DevToolsManager();
// Opend developer tools window for |web_contents|. If there is already
@@ -43,6 +47,11 @@
const IPC::Message& message);
private:
+ // Creates a DevToolsWindow using devtools_window_factory_ or by calling
+ // DevToolsWindow::Create, if the factory is NULL. All DevToolsWindows should
+ // be created by means of this method.
+ DevToolsWindow* CreateDevToolsWindow(DevToolsInstanceDescriptor* descriptor);
+
// NotificationObserver override.
virtual void Observe(NotificationType type,
const NotificationSource& source,
@@ -72,6 +81,7 @@
typedef std::map<NavigationController*,
DevToolsInstanceDescriptorImpl*> DescriptorMap;
DescriptorMap navcontroller_to_descriptor_;
+ DevToolsWindowFactory* devtools_window_factory_;
DISALLOW_COPY_AND_ASSIGN(DevToolsManager);
};
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/debugger/devtools_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698