Add unit tests for DevToolsManager

chrome/browser/debugger/devtools_manager.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/debugger/devtools_manager.h"
 
-#include "chrome/browser/browser_process.h"
 #include "chrome/browser/debugger/devtools_window.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
-#include "chrome/browser/tab_contents/render_view_host_manager.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/tab_contents/web_contents.h"
 #include "chrome/common/notification_registrar.h"
 #include "chrome/common/notification_type.h"
 
 
 class DevToolsInstanceDescriptorImpl : public DevToolsInstanceDescriptor {
  public:
   explicit DevToolsInstanceDescriptorImpl(
+      DevToolsManager* manager,
       NavigationController* navigation_controller)
-      : navigation_controller_(navigation_controller),
+      : manager_(manager),
+        navigation_controller_(navigation_controller),
         devtools_host_(NULL),
         devtools_window_(NULL) {
   }
   virtual ~DevToolsInstanceDescriptorImpl() {}
 
   virtual void SetDevToolsHost(RenderViewHost* render_view_host) {
     devtools_host_ = render_view_host;
   }
 
   virtual void SetDevToolsWindow(DevToolsWindow* window) {
     devtools_window_ = window;
   }
 
   virtual void Destroy() {
-    DevToolsManager* manager = g_browser_process->devtools_manager();
-    DCHECK(manager);
-    if (manager) {
-      manager->RemoveDescriptor(this);
-    }
+    manager_->RemoveDescriptor(this);
     delete this;
   }
 
   RenderViewHost* devtools_host() const {
     return devtools_host_;
   }
 
   DevToolsWindow* devtools_window() const {
     return devtools_window_;
   }
 
   NavigationController* navigation_controller() const {
     return navigation_controller_;
   }
 
  private:
+  DevToolsManager* manager_;
   NavigationController* navigation_controller_;
   RenderViewHost* devtools_host_;
   DevToolsWindow* devtools_window_;
 
   DISALLOW_COPY_AND_ASSIGN(DevToolsInstanceDescriptorImpl);
 };
 
-DevToolsManager::DevToolsManager() : web_contents_listeners_(NULL) {
+DevToolsManager::DevToolsManager(DevToolsWindowFactory* factory)
+    : web_contents_listeners_(NULL),
+      devtools_window_factory_(factory) {
 }
 
 DevToolsManager::~DevToolsManager() {
   DCHECK(!web_contents_listeners_.get()) <<
       "All devtools windows must alredy have been closed.";
 }
 
+DevToolsWindow* DevToolsManager::CreateDevToolsWindow(
+    DevToolsInstanceDescriptor* descriptor) {
+  if (devtools_window_factory_) {
+    return devtools_window_factory_->CreateDevToolsWindow(descriptor);
+  } else {
+    return DevToolsWindow::Create(descriptor);
+  }
+}
+
 void DevToolsManager::Observe(NotificationType type,
                               const NotificationSource& source,
                               const NotificationDetails& details) {
   DCHECK(type == NotificationType::WEB_CONTENTS_DISCONNECTED);
   Source<WebContents> src(source);
   NavigationController* controller = src->controller();
   DescriptorMap::const_iterator it =
       navcontroller_to_descriptor_.find(controller);
   if (it == navcontroller_to_descriptor_.end()) {
     return;
@@ skipping 11 matching lines @@
   NavigationController* navigation_controller = web_contents->controller();
 
   DevToolsWindow* window(NULL);
   DevToolsInstanceDescriptorImpl* desc(NULL);
   DescriptorMap::const_iterator it =
       navcontroller_to_descriptor_.find(navigation_controller);
   if (it != navcontroller_to_descriptor_.end()) {
     desc = it->second;
     window = desc->devtools_window();
   } else {
-    desc = new DevToolsInstanceDescriptorImpl(navigation_controller);
+    desc = new DevToolsInstanceDescriptorImpl(this, navigation_controller);
     navcontroller_to_descriptor_[navigation_controller] = desc;
 
     StartListening(navigation_controller);
 
-    window = DevToolsWindow::Create(desc);
+    window = CreateDevToolsWindow(desc);
   }
 
   window->Show();
 }
 
 void DevToolsManager::ForwardToDevToolsAgent(RenderViewHost* from,
                                              const IPC::Message& message) {
   NavigationController* nav_controller(NULL);
   for (DescriptorMap::const_iterator it = navcontroller_to_descriptor_.begin();
        it != navcontroller_to_descriptor_.end();
@@ skipping 74 matching lines @@
   }
 }
 
 void DevToolsManager::StopListening(
     NavigationController* navigation_controller) {
   DCHECK(web_contents_listeners_.get());
   if (navcontroller_to_descriptor_.empty()) {
     web_contents_listeners_.reset();
   }
 }