Review request: fix issue 8649 -- RTL: Wrong parenthesis direction is displayed on "About Google Chr

This CL fix issue 8649 -- RTL: Wrong parenthesis direction is displayed on "About Google Chrome" dialog
(http://crbug.com/8649).

The fix is to adjust the string according to locale,
so that the pure English string in RTL locale is surrounded by left-right-embedding mark for parenthesis to be displayed correctly.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12540

[jeremy, 2009-03-15 07:17:27]

Can this be fixed by changing the strings in the translation console?
Can you provide before/after screenshots?
Thanks :)

[Finnur, 2009-03-15 15:25:30]

Look at the bug for the 'before' screenshot. The 'after' scenario should be
obvious from that.

On 2009/03/15 07:17:27, jeremy wrote:
> Can this be fixed by changing the strings in the translation console?
> Can you provide before/after screenshots?
> Thanks :)

[jungshik at Google, 2009-03-16 18:11:34]

On 2009/03/15 07:17:27, jeremy wrote:
> Can this be fixed by changing the strings in the translation console?
> Can you provide before/after screenshots?
> Thanks :)

Arabic translation seems 'correct' as far as I can tell (which is not that far
:-)). 

 U+003e U+0647 U+0630 U+0627  U+0020 U+0623 U+062d U+062f
 U+062b U+0020 U+0625 U+0635  U+062f U+0627 U+0631 U+0020
 U+0645 U+0646 U+0020 U+003c  U+0070 U+0068 U+0020 U+006e
 U+0061 U+006d U+0065 U+003d  U+0022 U+0050 U+0052 U+004f
 U+0044 U+0055 U+0043 U+0054  U+005f U+004e U+0041 U+004d
 U+0045 U+0022 U+002f U+003e  U+0020 U+0020 U+0028 U+003c
 U+0070 U+0068 U+0020 U+006e  U+0061 U+006d U+0065 U+003d
 U+0022 U+0056 U+0045 U+0052  U+0053 U+0049 U+004f U+004e
 U+0022 U+002f U+003e U+0029

Hebrew translation is a bit strange. It does not have an opening parenthesis. 

 U+003e U+003c U+0070 U+0068  U+0020 U+006e U+0061 U+006d  |.>.<.p.h. .n.a.m|
 U+0065 U+003d U+0022 U+0050  U+0052 U+004f U+0044 U+0055  |.e.=.".P.R.O.D.U|
 U+0043 U+0054 U+005f U+004e  U+0041 U+004d U+0045 U+0022  |.C.T._.N.A.M.E."|
 U+002f U+003e U+0020 U+05de  U+05e2 U+05d5 U+05d3 U+05db  |./.>. ..........|
 U+05df U+0020 U+003c U+0070  U+0068 U+0020 U+006e U+0061  |... .<.p.h. .n.a|
 U+006d U+0065 U+003d U+0022  U+0056 U+0045 U+0052 U+0053  |.m.e.=.".V.E.R.S|
 U+0049 U+004f U+004e U+0022  U+002f U+003e U+0029         |.I.O.N."./.>.)

Anyway, I think we need this patch in addition to correcting Hebrew translation
(if there's indeed a problem).

[xji, 2009-03-26 01:34:16]

On 2009/03/15 07:17:27, jeremy wrote:
> Can this be fixed by changing the strings in the translation console?
> Can you provide before/after screenshots?
> Thanks :)

paste the email send to Jeremy here.
I also attached the screen shot in the email.
Please review. 

Since the parentheses is around version number, which wont be different in local
translation, I think it should be fixed in the code. (Or maybe we can re-order
the string to make the "(version)" part in the middle of the whole string for he
and ar?)
 
I uploaded the right fix and attached the snapshots here.


"he" has a translation problem -- missing "(". I will file a bug on it, and whom
should I assign it to?

[jeremy, 2009-03-26 02:17:34]

LGTM

[idana, 2009-03-26 06:06:16]

LGTM

Just one nit comment.

http://codereview.chromium.org/42096/diff/3001/3002
File chrome/browser/views/about_chrome_view.cc (right):

http://codereview.chromium.org/42096/diff/3001/3002#newcode769
Line 769:
update_label_text.push_back(static_cast<wchar_t>(l10n_util::kLeftToRightMark));
Line exceeds 80 characters.