Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2684)

Unified Diff: chrome/browser/views/about_chrome_view.cc

Issue 42096: Review request: fix issue 8649 -- RTL: Wrong parenthesis direction is displayed on "About Google Chr (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/about_chrome_view.cc
===================================================================
--- chrome/browser/views/about_chrome_view.cc (revision 11541)
+++ chrome/browser/views/about_chrome_view.cc (working copy)
@@ -761,10 +761,14 @@
!installed_version->IsHigherThan(running_version.get())) {
UserMetrics::RecordAction(L"UpgradeCheck_AlreadyUpToDate", profile_);
check_button_status_ = CHECKBUTTON_HIDDEN;
- update_label_.SetText(
+ std::wstring update_label_text =
l10n_util::GetStringF(IDS_UPGRADE_ALREADY_UP_TO_DATE,
l10n_util::GetString(IDS_PRODUCT_NAME),
- current_version_));
+ current_version_);
+ if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) {
+ update_label_text.push_back(static_cast<wchar_t>(l10n_util::kLeftToRightMark));
idana 2009/03/26 06:06:17 Line exceeds 80 characters.
+ }
+ update_label_.SetText(update_label_text);
show_success_indicator = true;
break;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698