Review request: fix issue 8649 -- RTL: Wrong parenthesis direction is displayed on "About Google Chr

chrome/browser/views/about_chrome_view.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/about_chrome_view.h"
 
 #include <commdlg.h>
 
 #include "base/file_version_info.h"
 #include "base/string_util.h"
@@ skipping 743 matching lines @@
       // are running the latest version and if not, notify the user by falling
       // into the next case of UPGRADE_SUCCESSFUL.
       scoped_ptr<installer::Version> installed_version(
           InstallUtil::GetChromeVersion(false));
       scoped_ptr<installer::Version> running_version(
           installer::Version::GetVersionFromString(current_version_));
       if (!installed_version.get() ||
           !installed_version->IsHigherThan(running_version.get())) {
         UserMetrics::RecordAction(L"UpgradeCheck_AlreadyUpToDate", profile_);
         check_button_status_ = CHECKBUTTON_HIDDEN;
-        update_label_.SetText(
+        std::wstring update_label_text =
             l10n_util::GetStringF(IDS_UPGRADE_ALREADY_UP_TO_DATE,
                                   l10n_util::GetString(IDS_PRODUCT_NAME),
-                                  current_version_));
+                                  current_version_);
+        if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) {
+          update_label_text.push_back(static_cast<wchar_t>(l10n_util::kLeftToRightMark));

[idana, 2009/03/26 06:06:17]

Line exceeds 80 characters.

+        }
+        update_label_.SetText(update_label_text);
         show_success_indicator = true;
         break;
       }
       // No break here as we want to notify user about upgrade if there is one.
     }
     case UPGRADE_SUCCESSFUL: {
       if (result == UPGRADE_ALREADY_UP_TO_DATE)
         UserMetrics::RecordAction(L"UpgradeCheck_AlreadyUpgraded", profile_);
       else
         UserMetrics::RecordAction(L"UpgradeCheck_Upgraded", profile_);
@@ skipping 32 matching lines @@
 
   // We have updated controls on the parent, so we need to update its layout.
   View* parent = GetParent();
   parent->Layout();
 
   // Check button may have appeared/disappeared. We cannot call this during
   // ViewHierarchyChanged because the |window()| pointer hasn't been set yet.
   if (window())
     GetDialogClientView()->UpdateDialogButtons();
 }