Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 42008: Introduce a BreakTarget subclass of JumpTarget used to represent the... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Introduce a BreakTarget subclass of JumpTarget used to represent the blocks labeled by "break", "continue", and "return". BreakTargets are the only jump targets that appear in the AST, the only ones that can be uninitialized, and the only ones that can be shadowed. Committed: http://code.google.com/p/v8/source/detail?r=1475

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -104 lines) Patch
M src/ast.h View 7 chunks +13 lines, -13 lines 0 comments Download
M src/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen-arm.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/codegen-arm.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/codegen-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen-ia32.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/jump-target.h View 1 7 chunks +55 lines, -34 lines 0 comments Download
M src/jump-target.cc View 1 4 chunks +28 lines, -34 lines 0 comments Download
M src/parser.cc View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
Part I.
11 years, 9 months ago (2009-03-10 12:03:21 UTC) #1
Kasper Lund
11 years, 9 months ago (2009-03-10 12:07:01 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698