Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/dom_ui/dom_ui_factory.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: fix presubmit Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/chrome_url_data_manager.cc ('k') | chrome/browser/dom_ui/fileicon_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/dom_ui_factory.cc
diff --git a/chrome/browser/dom_ui/dom_ui_factory.cc b/chrome/browser/dom_ui/dom_ui_factory.cc
index aaeb4e38188baf6af8489f27aabcbe455facf1a7..cb2e30ddb17f53d28e759c54a62e0ddd26536549 100644
--- a/chrome/browser/dom_ui/dom_ui_factory.cc
+++ b/chrome/browser/dom_ui/dom_ui_factory.cc
@@ -242,8 +242,8 @@ void DOMUIFactory::GetFaviconForURL(Profile* profile,
page_url.host() != extension_misc::kBookmarkManagerId) {
ExtensionDOMUI::GetFaviconForURL(profile, request, page_url);
} else {
- scoped_refptr<RefCountedMemory> icon_data =
- DOMUIFactory::GetFaviconResourceBytes(profile, page_url);
+ scoped_refptr<RefCountedMemory> icon_data(
+ DOMUIFactory::GetFaviconResourceBytes(profile, page_url));
bool know_icon = icon_data.get() != NULL && icon_data->size() > 0;
request->ForwardResultAsync(
FaviconService::FaviconDataCallback::TupleType(request->handle(),
« no previous file with comments | « chrome/browser/dom_ui/chrome_url_data_manager.cc ('k') | chrome/browser/dom_ui/fileicon_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698