chrome/browser/dom_ui/fileicon_source.cc - Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_ui/fileicon_source.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: fix presubmit Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/dom_ui/fileicon_source.cc

diff --git a/chrome/browser/dom_ui/fileicon_source.cc b/chrome/browser/dom_ui/fileicon_source.cc

index 599c7551f7ff200979f249fc68c2d911e70f8c6b..7572cdc8d0014a918548a3744e053e87425c3893 100644

--- a/chrome/browser/dom_ui/fileicon_source.cc

+++ b/chrome/browser/dom_ui/fileicon_source.cc

@@ -43,7 +43,7 @@ void FileIconSource::StartDataRequest(const std::string& path,

SkBitmap* icon = im->LookupIcon(escaped_filepath, IconLoader::NORMAL);

if (icon) {

- scoped_refptr<RefCountedBytes> icon_data = new RefCountedBytes;

+ scoped_refptr<RefCountedBytes> icon_data(new RefCountedBytes);

gfx::PNGCodec::EncodeBGRASkBitmap(*icon, false, &icon_data->data);

SendResponse(request_id, icon_data);

@@ -65,7 +65,7 @@ void FileIconSource::OnFileIconDataAvailable(IconManager::Handle handle,

int request_id = cancelable_consumer_.GetClientData(im, handle);

if (icon) {

- scoped_refptr<RefCountedBytes> icon_data = new RefCountedBytes;

+ scoped_refptr<RefCountedBytes> icon_data(new RefCountedBytes);

gfx::PNGCodec::EncodeBGRASkBitmap(*icon, false, &icon_data->data);

SendResponse(request_id, icon_data);

« no previous file with comments | « chrome/browser/dom_ui/dom_ui_factory.cc ('k') | chrome/browser/dom_ui/new_tab_ui.cc » ('j') | no next file with comments »