chrome/browser/dom_ui/chrome_url_data_manager.cc - Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_ui/chrome_url_data_manager.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: fix presubmit Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/device_orientation/device_orientation_browsertest.cc ('k') | chrome/browser/dom_ui/dom_ui_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/dom_ui/chrome_url_data_manager.cc

diff --git a/chrome/browser/dom_ui/chrome_url_data_manager.cc b/chrome/browser/dom_ui/chrome_url_data_manager.cc

index dfa778586305fbdb92900ac81526490ddb1d8226..b793ed836dfccd92acb8354a2a9a650feb596662 100644

--- a/chrome/browser/dom_ui/chrome_url_data_manager.cc

+++ b/chrome/browser/dom_ui/chrome_url_data_manager.cc

@@ -269,7 +269,7 @@ void ChromeURLDataManager::DataAvailable(

if (i != pending_requests_.end()) {

// We acquire a reference to the job so that it doesn't disappear under the

// feet of any method invoked here (we could trigger a callback).

- scoped_refptr<URLRequestChromeJob> job = i->second;

+ scoped_refptr<URLRequestChromeJob> job(i->second);

pending_requests_.erase(i);

job->DataAvailable(bytes);

}

« no previous file with comments | « chrome/browser/device_orientation/device_orientation_browsertest.cc ('k') | chrome/browser/dom_ui/dom_ui_factory.cc » ('j') | no next file with comments »