Issue 4135007: Add a bunch of missing bug references to FLAKY tests

Issue 4135007: Add a bunch of missing bug references to FLAKY tests (Closed)

Created:
10 years, 1 month ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, stuartmorgan1

CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add a bunch of missing bug references to FLAKY tests BUG=None TEST=N/A Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64150

Patch Set 2 : Add TODO #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
M	chrome/browser/appcache/appcache_ui_test.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browser_init_browsertest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_uitest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/session_history_uitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sessions/session_restore_uitest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_restore_uitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/unload_uitest.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/test/plugin/plugin_test.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/ui/layout_plugin_uitest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/worker/worker_uitest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/socket/ssl_client_socket_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	sandbox/src/unload_dll_test.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://codereview.chromium.org/4135007/diff/1/5 File chrome/browser/session_history_uitest.cc (left): http://codereview.chromium.org/4135007/diff/1/5#oldcode142 chrome/browser/session_history_uitest.cc:142: // Fails on Windows. See crbug.com/TODO nice http://codereview.chromium.org/4135007/diff/1/8 File ...

10 years, 1 month ago (2010-10-27 20:19:17 UTC) #2

stuartmorgan1

http://codereview.chromium.org/4135007/diff/1/8 File chrome/browser/unload_uitest.cc (right): http://codereview.chromium.org/4135007/diff/1/8#newcode417 chrome/browser/unload_uitest.cc:417: // Flaky on Linux under valgrind. http://crbug.com/46781 On 2010/10/27 ...

10 years, 1 month ago (2010-10-27 20:55:42 UTC) #3

Lei Zhang

10 years, 1 month ago (2010-10-27 20:59:26 UTC) #4

http://codereview.chromium.org/4135007/diff/1/8
File chrome/browser/unload_uitest.cc (right):

http://codereview.chromium.org/4135007/diff/1/8#newcode417
chrome/browser/unload_uitest.cc:417: // Flaky on Linux under valgrind.
http://crbug.com/46781
On 2010/10/27 20:55:42, stuartmorgan1 wrote:
> On 2010/10/27 20:19:17, Lei Zhang wrote:
> > shouldn't this be marked unflaky and instead disabled on Valgrind?
> 
> Likely, but I don't want to do that in this CL in case flakiness has crept
into
> the non-valgrind world too. I'll revisit with the more substantive changes I
> need to make to various tests in follow-ups.

If you can add a TODO to remind as a reminder, then LGTM.

Expand Messages | Collapse Messages