Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: chrome/browser/extensions/extension_uitest.cc

Issue 4135007: Add a bunch of missing bug references to FLAKY tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add TODO Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/browser_init_browsertest.cc ('k') | chrome/browser/session_history_uitest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/json/json_reader.h" 6 #include "base/json/json_reader.h"
7 #include "base/json/json_writer.h" 7 #include "base/json/json_writer.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "chrome/browser/automation/extension_automation_constants.h" 9 #include "chrome/browser/automation/extension_automation_constants.h"
10 #include "chrome/browser/extensions/extension_tabs_module_constants.h" 10 #include "chrome/browser/extensions/extension_tabs_module_constants.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 // universal forwarding. 114 // universal forwarding.
115 functions_enabled_.clear(); 115 functions_enabled_.clear();
116 functions_enabled_.push_back("tabs.remove"); 116 functions_enabled_.push_back("tabs.remove");
117 ExtensionUITest::SetUp(); 117 ExtensionUITest::SetUp();
118 } 118 }
119 119
120 private: 120 private:
121 DISALLOW_COPY_AND_ASSIGN(ExtensionTestSimpleApiCall); 121 DISALLOW_COPY_AND_ASSIGN(ExtensionTestSimpleApiCall);
122 }; 122 };
123 123
124 // Flaky: http://crbug.com/44599
124 TEST_F(ExtensionTestSimpleApiCall, FLAKY_RunTest) { 125 TEST_F(ExtensionTestSimpleApiCall, FLAKY_RunTest) {
125 namespace keys = extension_automation_constants; 126 namespace keys = extension_automation_constants;
126 127
127 ASSERT_THAT(mock_, testing::NotNull()); 128 ASSERT_THAT(mock_, testing::NotNull());
128 EXPECT_CALL(*mock_, OnDidNavigate(_, _)).Times(1); 129 EXPECT_CALL(*mock_, OnDidNavigate(_, _)).Times(1);
129 EXPECT_CALL(*mock_, OnNavigationStateChanged(_, _, _)) 130 EXPECT_CALL(*mock_, OnNavigationStateChanged(_, _, _))
130 .Times(testing::AnyNumber()); 131 .Times(testing::AnyNumber());
131 132
132 std::string message_received; 133 std::string message_received;
133 EXPECT_CALL(*mock_, OnForwardMessageToExternalHost( 134 EXPECT_CALL(*mock_, OnForwardMessageToExternalHost(
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
479 ASSERT_EQ(arraysize(events_), event_count_.size()); 480 ASSERT_EQ(arraysize(events_), event_count_.size());
480 for (std::map<std::string, int>::iterator i = event_count_.begin(); 481 for (std::map<std::string, int>::iterator i = event_count_.begin();
481 i != event_count_.end(); ++i) { 482 i != event_count_.end(); ++i) {
482 const std::pair<std::string, int>& value = *i; 483 const std::pair<std::string, int>& value = *i;
483 EXPECT_EQ(1, value.second); 484 EXPECT_EQ(1, value.second);
484 } 485 }
485 } 486 }
486 #endif // defined(OS_WIN) 487 #endif // defined(OS_WIN)
487 488
488 } // namespace 489 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/browser_init_browsertest.cc ('k') | chrome/browser/session_history_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698