chrome/browser/unload_uitest.cc - Issue 4135007: Add a bunch of missing bug references to FLAKY tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/unload_uitest.cc

Issue 4135007: Add a bunch of missing bug references to FLAKY tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add TODO Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/unload_uitest.cc

diff --git a/chrome/browser/unload_uitest.cc b/chrome/browser/unload_uitest.cc

index 3ddd9b0e34bb2e2acc56f635a006851b702b901d..6abc7369e97753599e94dce1649e9649cd12564e 100644

--- a/chrome/browser/unload_uitest.cc

+++ b/chrome/browser/unload_uitest.cc

@@ -324,7 +324,7 @@ TEST_F(UnloadTest, BrowserCloseBeforeUnloadCancel) {

}

#if defined(OS_LINUX)

-// Fails sometimes on Linux valgrind. http://crbug.com/32615

+// Fails sometimes on Linux valgrind. http://crbug.com/45675

#define MAYBE_BrowserCloseWithInnerFocusedFrame \

FLAKY_BrowserCloseWithInnerFocusedFrame

#else

@@ -414,7 +414,8 @@ TEST_F(UnloadTest, BrowserCloseTwoSecondBeforeUnloadAlert) {

#define MAYBE_BrowserCloseTabWhenOtherTabHasListener \

DISABLED_BrowserCloseTabWhenOtherTabHasListener

#else

-// Flaky on Linux as well. http://crbug.com/45562

+// Flaky on Linux under valgrind. http://crbug.com/46781

+// TODO(stuartmorgan): Switch to just disabling for valgrind.

#define MAYBE_BrowserCloseTabWhenOtherTabHasListener \

FLAKY_BrowserCloseTabWhenOtherTabHasListener

#endif

« no previous file with comments | « chrome/browser/tab_restore_uitest.cc ('k') | chrome/test/plugin/plugin_test.cpp » ('j') | no next file with comments »