Fix a bug that could occur when converting strings with leading characters ab...

base/string_number_conversions_unittest.cc

Index: base/string_number_conversions_unittest.cc
===================================================================
--- base/string_number_conversions_unittest.cc	(revision 63369)
+++ base/string_number_conversions_unittest.cc	(working copy)
@@ -80,6 +80,8 @@
   } cases[] = {
     {"0", 0, true},
     {"42", 42, true},
+    {"42\x99", 42, false},
+    {"\x99" "42\x99", 0, false},
     {"-2147483648", INT_MIN, true},
     {"2147483647", INT_MAX, true},
     {"", 0, false},
@@ -161,6 +163,11 @@
                            utf16_chars + utf16_input.length(),
                            &output));
   EXPECT_EQ(6, output);
+
+  output = 0;
+  const char16 negative_wide_input[] = { 0xFF4D, '4', '2', 0};

[MAD, 2010/11/02 18:53:25]

I was wondering about that... But didn't mention since I guess you had tried
building the patch... Next time I'll mention it anyway... :-)

[erikwright (departed), 2010/11/02 19:32:22]

The other one did build on Win (locally), but I was having trouble with 'gcl
try' that prevented me from submitting the job to linux+mac. Finally had to
submit a CL to depot_tools to get it to work.

+  EXPECT_FALSE(StringToInt(string16(negative_wide_input), &output));
+  EXPECT_EQ(0, output);
 }
 
 TEST(StringNumberConversionsTest, StringToInt64) {