Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Issue 4087009: Update a bunch of FLAKY_ tests to match current reality (Closed)

Created:
10 years, 1 month ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, amit, Paweł Hajdan Jr.
Visibility:
Public.

Description

Update a bunch of FLAKY_ tests to match current reality Mostly this is removing FLAKY_ where the bug was fixed but the label never removed, but also switches some FLAKY_ to platform-specific FAILS_. BUG=28372, 32048, 32070, 35341, 45561, 48544, 48562, 52858 TEST=N/A Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -45 lines) Patch
M base/debug/stack_trace_unittest.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_service_uitest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/logging_chrome_uitest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/test/startup/shutdown_test.cc View 1 chunk +3 lines, -14 lines 0 comments Download
M chrome/test/startup/startup_test.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/test/ui/npapi_uitest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome_frame/test/test_with_web_server.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
stuartmorgan
10 years, 1 month ago (2010-10-27 23:54:09 UTC) #1
Lei Zhang
10 years, 1 month ago (2010-10-28 01:01:18 UTC) #2
Rubberstamp LGTM

Powered by Google App Engine
This is Rietveld 408576698