Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: chrome/test/startup/shutdown_test.cc

Issue 4087009: Update a bunch of FLAKY_ tests to match current reality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/common/logging_chrome_uitest.cc ('k') | chrome/test/startup/startup_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/environment.h" 5 #include "base/environment.h"
6 #include "base/file_util.h" 6 #include "base/file_util.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/platform_thread.h" 8 #include "base/platform_thread.h"
9 #include "base/string_number_conversions.h" 9 #include "base/string_number_conversions.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 TEST_F(ShutdownTest, SimpleWindowClose) { 115 TEST_F(ShutdownTest, SimpleWindowClose) {
116 RunShutdownTest("shutdown", "simple-window-close", 116 RunShutdownTest("shutdown", "simple-window-close",
117 true, /* important */ SIMPLE, UITest::WINDOW_CLOSE); 117 true, /* important */ SIMPLE, UITest::WINDOW_CLOSE);
118 } 118 }
119 119
120 TEST_F(ShutdownTest, SimpleUserQuit) { 120 TEST_F(ShutdownTest, SimpleUserQuit) {
121 RunShutdownTest("shutdown", "simple-user-quit", 121 RunShutdownTest("shutdown", "simple-user-quit",
122 true, /* important */ SIMPLE, UITest::USER_QUIT); 122 true, /* important */ SIMPLE, UITest::USER_QUIT);
123 } 123 }
124 124
125 // http://crbug.com/52858 125 TEST_F(ShutdownTest, SimpleSessionEnding) {
126 #if defined(OS_MACOSX)
127 #define MAYBE_SimpleSessionEnding FLAKY_SimpleSessionEnding
128 #define MAYBE_TwentyTabsWindowClose FLAKY_TwentyTabsWindowClose
129 #define MAYBE_TwentyTabsUserQuit FLAKY_TwentyTabsUserQuit
130 #else
131 #define MAYBE_SimpleSessionEnding SimpleSessionEnding
132 #define MAYBE_TwentyTabsWindowClose TwentyTabsWindowClose
133 #define MAYBE_TwentyTabsUserQuit TwentyTabsUserQuit
134 #endif
135
136 TEST_F(ShutdownTest, MAYBE_SimpleSessionEnding) {
137 RunShutdownTest("shutdown", "simple-session-ending", 126 RunShutdownTest("shutdown", "simple-session-ending",
138 true, /* important */ SIMPLE, UITest::SESSION_ENDING); 127 true, /* important */ SIMPLE, UITest::SESSION_ENDING);
139 } 128 }
140 129
141 TEST_F(ShutdownTest, MAYBE_TwentyTabsWindowClose) { 130 TEST_F(ShutdownTest, TwentyTabsWindowClose) {
142 RunShutdownTest("shutdown", "twentytabs-window-close", 131 RunShutdownTest("shutdown", "twentytabs-window-close",
143 true, /* important */ TWENTY_TABS, UITest::WINDOW_CLOSE); 132 true, /* important */ TWENTY_TABS, UITest::WINDOW_CLOSE);
144 } 133 }
145 134
146 TEST_F(ShutdownTest, MAYBE_TwentyTabsUserQuit) { 135 TEST_F(ShutdownTest, TwentyTabsUserQuit) {
147 RunShutdownTest("shutdown", "twentytabs-user-quit", 136 RunShutdownTest("shutdown", "twentytabs-user-quit",
148 true, /* important */ TWENTY_TABS, UITest::USER_QUIT); 137 true, /* important */ TWENTY_TABS, UITest::USER_QUIT);
149 } 138 }
150 139
151 // http://crbug.com/40671 140 // http://crbug.com/40671
152 #if defined(OS_WIN) && !defined(NDEBUG) 141 #if defined(OS_WIN) && !defined(NDEBUG)
153 #define MAYBE_TwentyTabsSessionEnding DISABLED_TwentyTabsSessionEnding 142 #define MAYBE_TwentyTabsSessionEnding DISABLED_TwentyTabsSessionEnding
154 #else 143 #else
155 #define MAYBE_TwentyTabsSessionEnding TwentyTabsSessionEnding 144 #define MAYBE_TwentyTabsSessionEnding TwentyTabsSessionEnding
156 #endif 145 #endif
157 146
158 TEST_F(ShutdownTest, MAYBE_TwentyTabsSessionEnding) { 147 TEST_F(ShutdownTest, MAYBE_TwentyTabsSessionEnding) {
159 RunShutdownTest("shutdown", "twentytabs-session-ending", 148 RunShutdownTest("shutdown", "twentytabs-session-ending",
160 true, /* important */ TWENTY_TABS, UITest::SESSION_ENDING); 149 true, /* important */ TWENTY_TABS, UITest::SESSION_ENDING);
161 } 150 }
162 151
163 } // namespace 152 } // namespace
OLDNEW
« no previous file with comments | « chrome/common/logging_chrome_uitest.cc ('k') | chrome/test/startup/startup_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698