Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

Issue 4087009: Update a bunch of FLAKY_ tests to match current reality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 #include <string> 6 #include <string>
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 L"Content Sniffer Test 0", 1); 184 L"Content Sniffer Test 0", 1);
185 185
186 // Check that the cookie was set. 186 // Check that the cookie was set.
187 std::string value_result; 187 std::string value_result;
188 ASSERT_TRUE(tab->GetCookieByName(url, "onunloadCookie", &value_result)); 188 ASSERT_TRUE(tab->GetCookieByName(url, "onunloadCookie", &value_result));
189 ASSERT_FALSE(value_result.empty()); 189 ASSERT_FALSE(value_result.empty());
190 ASSERT_STREQ("foo", value_result.c_str()); 190 ASSERT_STREQ("foo", value_result.c_str());
191 } 191 }
192 192
193 #if !defined(OS_MACOSX) 193 #if !defined(OS_MACOSX)
194 #if defined(OS_WIN)
195 // http://crbug.com/32048
196 #define CrossSiteAfterCrash FLAKY_CrossSiteAfterCrash
197 #endif
198 // Tests that the onbeforeunload and onunload logic is shortcutted if the old 194 // Tests that the onbeforeunload and onunload logic is shortcutted if the old
199 // renderer is gone. In that case, we don't want to wait for the old renderer 195 // renderer is gone. In that case, we don't want to wait for the old renderer
200 // to run the handlers. 196 // to run the handlers.
201 // We need to disable this on Mac because the crash causes the OS CrashReporter 197 // We need to disable this on Mac because the crash causes the OS CrashReporter
202 // process to kick in to analyze the poor dead renderer. Unfortunately, if the 198 // process to kick in to analyze the poor dead renderer. Unfortunately, if the
203 // app isn't stripped of debug symbols, this takes about five minutes to 199 // app isn't stripped of debug symbols, this takes about five minutes to
204 // complete and isn't conducive to quick turnarounds. As we don't currently 200 // complete and isn't conducive to quick turnarounds. As we don't currently
205 // strip the app on the build bots, this is bad times. 201 // strip the app on the build bots, this is bad times.
206 TEST_F(ResourceDispatcherTest, CrossSiteAfterCrash) { 202 TEST_F(ResourceDispatcherTest, CrossSiteAfterCrash) {
207 // This test only works in multi-process mode 203 // This test only works in multi-process mode
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 GURL broken_url("chrome://theme"); 325 GURL broken_url("chrome://theme");
330 ASSERT_EQ(AUTOMATION_MSG_NAVIGATION_SUCCESS, tab->NavigateToURL(broken_url)); 326 ASSERT_EQ(AUTOMATION_MSG_NAVIGATION_SUCCESS, tab->NavigateToURL(broken_url));
331 327
332 // Make sure the navigation finishes. 328 // Make sure the navigation finishes.
333 std::wstring tab_title; 329 std::wstring tab_title;
334 EXPECT_TRUE(tab->GetTabTitle(&tab_title)); 330 EXPECT_TRUE(tab->GetTabTitle(&tab_title));
335 EXPECT_EQ(L"chrome://theme/ is not available", tab_title); 331 EXPECT_EQ(L"chrome://theme/ is not available", tab_title);
336 } 332 }
337 333
338 } // namespace 334 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/metrics/metrics_service_uitest.cc ('k') | chrome/common/logging_chrome_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698