Issue 402084: gclient: Fix bug where urls with revisions are not parsed correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 402084: gclient: Fix bug where urls with revisions are not parsed correctly. (Closed)

Created:
11 years, 1 month ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel, sosa

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

gclient: Fix bug where urls with revisions are not parsed correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32521

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	gclient_scm.py	View		1 chunk	+7 lines, -5 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 1 month ago (2009-11-19 18:36:52 UTC) #2

lgtm

http://codereview.chromium.org/402084/diff/1/2
File gclient_scm.py (right):

http://codereview.chromium.org/402084/diff/1/2#newcode30
Line 30: url, _ = gclient_utils.SplitUrlRevision(url)
smells go here. :)

Expand Messages | Collapse Messages