gclient: Fix bug where urls with revisions are not parsed correctly.

gclient_scm.py

Index: gclient_scm.py
diff --git a/gclient_scm.py b/gclient_scm.py
index c3c5377fd9e8f45733b56de2fbfd0ecd4d0a24d4..2b3f7aa702acf5ede91064c3f4714fa1938fe5bc 100644
--- a/gclient_scm.py
+++ b/gclient_scm.py
@@ -24,14 +24,16 @@ def CreateSCM(url=None, root_dir=None, relpath=None, scm_name='svn'):
     'git' : GitWrapper,
   }
 
-  if url and (url.startswith('git:') or
-              url.startswith('ssh:') or
-              url.endswith('.git')):
-    scm_name = 'git'
+  orig_url = url
+
+  if url:
+    url, _ = gclient_utils.SplitUrlRevision(url)

[M-A Ruel, 2009/11/19 18:36:52]

smells go here. :)

+    if url.startswith('git:') or url.startswith('ssh:') or url.endswith('.git'):
+      scm_name = 'git'
 
   if not scm_name in scm_map:
     raise gclient_utils.Error('Unsupported scm %s' % scm_name)
-  return scm_map[scm_name](url, root_dir, relpath, scm_name)
+  return scm_map[scm_name](orig_url, root_dir, relpath, scm_name)
 
 
 # SCMWrapper base class