gclient: Fix bug where urls with revisions are not parsed correctly.

gclient_scm.py

 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Gclient-specific SCM-specific operations."""
 
 import logging
 import os
 import re
 import subprocess
 
 import scm
 import gclient_utils
 
 
 ### SCM abstraction layer
 
 # Factory Method for SCM wrapper creation
 
 def CreateSCM(url=None, root_dir=None, relpath=None, scm_name='svn'):
   # TODO(maruel): Deduce the SCM from the url.
   scm_map = {
     'svn' : SVNWrapper,
     'git' : GitWrapper,
   }
 
-  if url and (url.startswith('git:') or
-              url.startswith('ssh:') or
-              url.endswith('.git')):
-    scm_name = 'git'
+  orig_url = url
+
+  if url:
+    url, _ = gclient_utils.SplitUrlRevision(url)

[M-A Ruel, 2009/11/19 18:36:52]

smells go here. :)

+    if url.startswith('git:') or url.startswith('ssh:') or url.endswith('.git'):
+      scm_name = 'git'
 
   if not scm_name in scm_map:
     raise gclient_utils.Error('Unsupported scm %s' % scm_name)
-  return scm_map[scm_name](url, root_dir, relpath, scm_name)
+  return scm_map[scm_name](orig_url, root_dir, relpath, scm_name)
 
 
 # SCMWrapper base class
 
 class SCMWrapper(object):
   """Add necessary glue between all the supported SCM.
 
   This is the abstraction layer to bind to different SCM. Since currently only
   subversion is supported, a lot of subersionism remains. This can be sorted out
   once another SCM is supported."""
@@ skipping 408 matching lines @@
           self.ReplaceAndPrint(line)
         else:
           if (line.startswith(self.original_prefix) or
               line.startswith(self.working_prefix)):
             self.ReplaceAndPrint(line)
           else:
             print line
 
     filterer = DiffFilterer(self.relpath)
     self.RunAndFilterOutput(command, path, False, False, filterer.Filter)